diff options
| author | Marcel Ziswiler <marcel.ziswiler@toradex.com> | 2020-11-19 12:12:45 +0100 |
|---|---|---|
| committer | Marcel Ziswiler <marcel.ziswiler@toradex.com> | 2020-11-19 18:48:49 +0100 |
| commit | b70ff1a83240942ab528ce3acb8f82cdd6c79a3f (patch) | |
| tree | 5b1a4bab60256fd1ea8f364570e58ea204464553 | |
| parent | f46a9075e794d4592f63feadbad62a7a0969d0d4 (diff) | |
fastboot: fix build warnings
Fix the following annoying build warnings:
drivers/fastboot/fb_fsl/fb_fsl_common.c: In function ‘fastboot_setup’:
drivers/fastboot/fb_fsl/fb_fsl_common.c:359:2: warning: ‘serialnr.high’ is used uninitialized in this function [-Wuninitialized]
359 | sprintf(serial, "%08x%08x", serialnr.high, serialnr.low);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/fastboot/fb_fsl/fb_fsl_common.c:359:2: warning: ‘serialnr.low’ is used uninitialized in this function [-Wuninitialized]
drivers/fastboot/fb_fsl/fb_fsl_getvar.c:117:13: warning: ‘serial’ defined but not used [-Wunused-variable]
117 | static char serial[IMX_SERIAL_LEN];
| ^~~~~~
Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
| -rw-r--r-- | drivers/fastboot/fb_fsl/fb_fsl_common.c | 5 | ||||
| -rw-r--r-- | drivers/fastboot/fb_fsl/fb_fsl_getvar.c | 2 |
2 files changed, 6 insertions, 1 deletions
diff --git a/drivers/fastboot/fb_fsl/fb_fsl_common.c b/drivers/fastboot/fb_fsl/fb_fsl_common.c index 13d8097a5f..97ff103405 100644 --- a/drivers/fastboot/fb_fsl/fb_fsl_common.c +++ b/drivers/fastboot/fb_fsl/fb_fsl_common.c @@ -352,7 +352,10 @@ static int _fastboot_setup_dev(int *switched) void fastboot_setup(void) { int sw, ret; - struct tag_serialnr serialnr; + struct tag_serialnr serialnr = { + .high = 0, + .low = 0, + }; char serial[17]; get_board_serial(&serialnr); diff --git a/drivers/fastboot/fb_fsl/fb_fsl_getvar.c b/drivers/fastboot/fb_fsl/fb_fsl_getvar.c index 99efda64d3..6ef3c18c11 100644 --- a/drivers/fastboot/fb_fsl/fb_fsl_getvar.c +++ b/drivers/fastboot/fb_fsl/fb_fsl_getvar.c @@ -114,7 +114,9 @@ static bool is_slotvar(char *cmd) return false; } +#ifdef CONFIG_SERIAL_TAG static char serial[IMX_SERIAL_LEN]; +#endif char *get_serial(void) { |