summaryrefslogtreecommitdiff
path: root/common/hash.c
diff options
context:
space:
mode:
authorJeroen Hofstee <jeroen@myspectrum.nl>2014-06-09 11:02:02 +0200
committerTom Rini <trini@ti.com>2014-06-11 16:27:05 -0400
commit8b9cc866c10787b057b4ac91c8783cfa752f1151 (patch)
tree4a9462b59d188da3ba7d3133a385b38c9f8dddb2 /common/hash.c
parentc71630838d908e410ee83f0164327e1fd515f1ca (diff)
common: hash: zero end the string instead of the pointer
if algo->digest_size is zero nothing is set in the str_output buffer. An attempt is made to zero end the buffer, but the pointer to the buffer is set to zero instead. I am unaware if it causes any actual problems, but solves the following warning: common/hash.c:217:13: warning: expression which evaluates to zero treated as a null pointer constant of type 'char *' [-Wnon-literal-null-conversion] str_ptr = '\0'; ^~~~ cc: Simon Glass <sjg@chromium.org> Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
Diffstat (limited to 'common/hash.c')
-rw-r--r--common/hash.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/common/hash.c b/common/hash.c
index 41a4a28437..237bd04bb1 100644
--- a/common/hash.c
+++ b/common/hash.c
@@ -214,7 +214,7 @@ static void store_result(struct hash_algo *algo, const u8 *sum,
sprintf(str_ptr, "%02x", sum[i]);
str_ptr += 2;
}
- str_ptr = '\0';
+ *str_ptr = '\0';
setenv(dest, str_output);
} else {
ulong addr;