summaryrefslogtreecommitdiff
path: root/drivers/delay_timer
diff options
context:
space:
mode:
authorSathees Balya <sathees.balya@arm.com>2018-09-19 14:23:03 +0100
committerSathees Balya <sathees.balya@arm.com>2018-09-25 17:49:28 +0100
commitd47509d6ac195d61c928cad8954d50200bad2205 (patch)
tree6a4775a5dd8d40859d957be2d8497b044ef7e7fd /drivers/delay_timer
parent9068257ea7e0242214f9e833410d9b3fc8bcbe45 (diff)
Fix misra warnings in delay timer and console drivers
Change-Id: I43d2b3a0f672b4902edec3d3a39ffedbb0a701a3 Signed-off-by: Sathees Balya <sathees.balya@arm.com>
Diffstat (limited to 'drivers/delay_timer')
-rw-r--r--drivers/delay_timer/delay_timer.c19
-rw-r--r--drivers/delay_timer/generic_delay_timer.c6
2 files changed, 13 insertions, 12 deletions
diff --git a/drivers/delay_timer/delay_timer.c b/drivers/delay_timer/delay_timer.c
index 587724eb..feac3579 100644
--- a/drivers/delay_timer/delay_timer.c
+++ b/drivers/delay_timer/delay_timer.c
@@ -20,20 +20,21 @@ static const timer_ops_t *timer_ops;
***********************************************************/
void udelay(uint32_t usec)
{
- assert(timer_ops != NULL &&
- (timer_ops->clk_mult != 0) &&
- (timer_ops->clk_div != 0) &&
+ assert((timer_ops != NULL) &&
+ (timer_ops->clk_mult != 0U) &&
+ (timer_ops->clk_div != 0U) &&
(timer_ops->get_timer_value != NULL));
uint32_t start, delta, total_delta;
- assert(usec < UINT32_MAX / timer_ops->clk_div);
+ assert(usec < (UINT32_MAX / timer_ops->clk_div));
start = timer_ops->get_timer_value();
/* Add an extra tick to avoid delaying less than requested. */
total_delta =
- div_round_up(usec * timer_ops->clk_div, timer_ops->clk_mult) + 1;
+ div_round_up(usec * timer_ops->clk_div,
+ timer_ops->clk_mult) + 1U;
do {
/*
@@ -51,7 +52,7 @@ void udelay(uint32_t usec)
***********************************************************/
void mdelay(uint32_t msec)
{
- udelay(msec*1000);
+ udelay(msec * 1000U);
}
/***********************************************************
@@ -60,9 +61,9 @@ void mdelay(uint32_t msec)
***********************************************************/
void timer_init(const timer_ops_t *ops_ptr)
{
- assert(ops_ptr != NULL &&
- (ops_ptr->clk_mult != 0) &&
- (ops_ptr->clk_div != 0) &&
+ assert((ops_ptr != NULL) &&
+ (ops_ptr->clk_mult != 0U) &&
+ (ops_ptr->clk_div != 0U) &&
(ops_ptr->get_timer_value != NULL));
timer_ops = ops_ptr;
diff --git a/drivers/delay_timer/generic_delay_timer.c b/drivers/delay_timer/generic_delay_timer.c
index 8a36c8ab..03ca5321 100644
--- a/drivers/delay_timer/generic_delay_timer.c
+++ b/drivers/delay_timer/generic_delay_timer.c
@@ -49,9 +49,9 @@ void generic_delay_timer_init(void)
unsigned int div = plat_get_syscnt_freq2();
/* Reduce multiplier and divider by dividing them repeatedly by 10 */
- while ((mult % 10 == 0) && (div % 10 == 0)) {
- mult /= 10;
- div /= 10;
+ while (((mult % 10U) == 0U) && ((div % 10U) == 0U)) {
+ mult /= 10U;
+ div /= 10U;
}
generic_delay_timer_init_args(mult, div);