summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLars-Peter Clausen <lars@metafoo.de>2011-11-16 20:34:04 +0100
committerLokesh Pathak <lpathak@nvidia.com>2012-03-05 07:53:19 -0800
commita87d1cd82c3581b50a33ccadaf279e4095bcf47f (patch)
treec9baa0c7a309cc970ecdcb5df748f24e8e7c854e
parentee046b3308a3245d2693d9cf7c987894476fa6cb (diff)
regmap: Drop check whether a register is readable in regcache_read
One of the reasons for using a cache is to have a software shadow of a register which is writable but not readable. This allows us to do a read-modify-write operation on such a register. Currently regcache checks whether a register is readable when performing a cached read and returns an error if it is not. Drop this check, since it will prevent us from using the cache for registers where read-back is not possible. Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com> (cherry picked from commit b44d48c1ccf70273a91b7d3a920b0b54c3cb314f) Change-Id: Iafe9afea14b09e69f698d71bcd1dd85695cc1ad5 Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com> Reviewed-on: http://git-master/r/87564
-rw-r--r--drivers/base/regmap/regcache.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/base/regmap/regcache.c b/drivers/base/regmap/regcache.c
index defa41d4344e..1679d12ee803 100644
--- a/drivers/base/regmap/regcache.c
+++ b/drivers/base/regmap/regcache.c
@@ -198,9 +198,6 @@ int regcache_read(struct regmap *map,
BUG_ON(!map->cache_ops);
- if (!regmap_readable(map, reg))
- return -EIO;
-
if (!regmap_volatile(map, reg))
return map->cache_ops->read(map, reg, value);