diff options
authorLinus Torvalds <>2012-07-07 10:17:00 -0700
committerMarcel Ziswiler <>2017-12-21 02:07:39 +0100
commit8882661bb6d0b0a1bf0d711683e6895abb64c40a (patch)
parentd7ac775674f2c302992311c92af50dee229faa5f (diff)
vfs: make O_PATH file descriptors usable for 'fchdir()'
We already use them for openat() and friends, but fchdir() also wants to be able to use O_PATH file descriptors. This should make it comparable to the O_SEARCH of Solaris. In particular, O_PATH allows you to access (not-quite-open) a directory you don't have read persmission to, only execute permission. Noticed during development of multithread support for ksh93. Reported-by: ольга крыжановская <> Cc: Al Viro <> Cc: # O_PATH introduced in 3.0+ Signed-off-by: Linus Torvalds <> (cherry picked from commit 332a2e1244bd08b9e3ecd378028513396a004a24) Signed-off-by: Dominik Sliwa <> Acked-by: Marcel Ziswiler <>
1 files changed, 3 insertions, 3 deletions
diff --git a/fs/open.c b/fs/open.c
index f71192109457..bc2e33de7967 100644
--- a/fs/open.c
+++ b/fs/open.c
@@ -396,10 +396,10 @@ SYSCALL_DEFINE1(fchdir, unsigned int, fd)
struct file *file;
struct inode *inode;
- int error;
+ int error, fput_needed;
error = -EBADF;
- file = fget(fd);
+ file = fget_raw_light(fd, &fput_needed);
if (!file)
goto out;
@@ -413,7 +413,7 @@ SYSCALL_DEFINE1(fchdir, unsigned int, fd)
if (!error)
set_fs_pwd(current->fs, &file->f_path);
- fput(file);
+ fput_light(file, fput_needed);
return error;