diff options
| author | Stefan Agner <stefan.agner@toradex.com> | 2018-11-05 16:33:29 +0100 |
|---|---|---|
| committer | Philippe Schenker <philippe.schenker@toradex.com> | 2018-11-06 10:37:04 +0100 |
| commit | de2360842dc6e1ece62d874ab8cc13f95fdd5a6f (patch) | |
| tree | 48790870db7a241a54d5608411605b6a7eb5446e | |
| parent | 496776ddb74fb2b2a203f917950e42b7421ea474 (diff) | |
phy: micrel: do not use power down mode
Some Micrel KSZ8041NL PHY chips exhibit continous RX errors after using the
power down mode bit (0.11). If the PHY is taken out of power down mode in a
certain temperature range, the PHY enters a weird state which leads to
continously reporting RX errors. In that state, the MAC is not able to receive
or send any Ethernet frames and the activity LED is constantly blinking. Since
Linux is using the suspend callback when the interface is taken down, ending up
in that state can easily happen during a normal startup.
Micrel confirmed the issue, caused by abnormal clock recovery when using power
down mode. Even the latest revision (A4, Revision ID 0x1513) seems to suffer
that problem.
Remove the suspend/resume callback to avoid using the power down mode
completely.
Signed-off-by: Stefan Agner <stefan.agner@toradex.com>
Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>
| -rw-r--r-- | drivers/net/phy/micrel.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c index 599275c355a5..80a8de5cd658 100644 --- a/drivers/net/phy/micrel.c +++ b/drivers/net/phy/micrel.c @@ -656,8 +656,6 @@ static struct phy_driver ksphy_driver[] = { .read_status = genphy_read_status, .ack_interrupt = kszphy_ack_interrupt, .config_intr = kszphy_config_intr, - .suspend = genphy_suspend, - .resume = genphy_resume, .driver = { .owner = THIS_MODULE,}, }, { .phy_id = PHY_ID_KSZ8041RNLI, |