diff options
| author | Pavel Emelyanov <xemul@openvz.org> | 2007-12-11 09:39:32 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2007-12-14 09:51:06 -0800 |
| commit | da027ec9500791ee49b3301d8ed7f12011d535e2 (patch) | |
| tree | 9d51f477c1b84a3b3af62f3a9fb61262b0ca8b20 | |
| parent | c8ddbf107012e54c432ba85192d18e873b8af1e5 (diff) | |
DECNET: dn_nl_deladdr() almost always returns no error
[DECNET]: dn_nl_deladdr() almost always returns no error
[ Upstream commit: 3ccd86241b277249d5ac08e91eddfade47184520 ]
As far as I see from the err variable initialization
the dn_nl_deladdr() routine was designed to report errors
like "EADDRNOTAVAIL" and probaby "ENODEV".
But the code sets this err to 0 after the first nlmsg_parse
and goes on, returning this 0 in any case.
Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Acked-by: Steven Whitehouse <swhiteho@redhat.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| -rw-r--r-- | net/decnet/dn_dev.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/net/decnet/dn_dev.c b/net/decnet/dn_dev.c index 8def68209edd..fbafa9780def 100644 --- a/net/decnet/dn_dev.c +++ b/net/decnet/dn_dev.c @@ -650,16 +650,18 @@ static int dn_nl_deladdr(struct sk_buff *skb, struct nlmsghdr *nlh, void *arg) struct dn_dev *dn_db; struct ifaddrmsg *ifm; struct dn_ifaddr *ifa, **ifap; - int err = -EADDRNOTAVAIL; + int err; err = nlmsg_parse(nlh, sizeof(*ifm), tb, IFA_MAX, dn_ifa_policy); if (err < 0) goto errout; + err = -ENODEV; ifm = nlmsg_data(nlh); if ((dn_db = dn_dev_by_index(ifm->ifa_index)) == NULL) goto errout; + err = -EADDRNOTAVAIL; for (ifap = &dn_db->ifa_list; (ifa = *ifap); ifap = &ifa->ifa_next) { if (tb[IFA_LOCAL] && nla_memcmp(tb[IFA_LOCAL], &ifa->ifa_local, 2)) |