diff options
| author | Laurent Pinchart <laurent.pinchart@ideasonboard.com> | 2010-04-25 16:27:14 -0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-07-05 11:22:56 -0700 |
| commit | eaeb91e532a4d68d51825bd0ed82f0955c9e3250 (patch) | |
| tree | f409bdbfd0cebd2cfd421848fe7dfa0c73234c56 | |
| parent | 135b48da0c911dbd8aa4c52742b9022643bc02a3 (diff) | |
V4L/DVB: uvcvideo: Prevent division by 0 when control step value is 0
commit cf7a50eeb6f462a0b7d1619fcb27a727a2981769 upstream.
The control step values reported by the device are used as a divisor
unchecked, which can result in a division by zero.
Check the step value and make it 1 when null.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| -rw-r--r-- | drivers/media/video/uvc/uvc_ctrl.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/media/video/uvc/uvc_ctrl.c b/drivers/media/video/uvc/uvc_ctrl.c index 6d3850b37161..2194da50f911 100644 --- a/drivers/media/video/uvc/uvc_ctrl.c +++ b/drivers/media/video/uvc/uvc_ctrl.c @@ -1047,6 +1047,8 @@ int uvc_ctrl_set(struct uvc_video_chain *chain, uvc_ctrl_data(ctrl, UVC_CTRL_DATA_MAX)); step = mapping->get(mapping, UVC_GET_RES, uvc_ctrl_data(ctrl, UVC_CTRL_DATA_RES)); + if (step == 0) + step = 1; xctrl->value = min + (xctrl->value - min + step/2) / step * step; xctrl->value = clamp(xctrl->value, min, max); |