diff options
authorStefan Nilsson XK <>2011-03-01 14:41:04 +0100
committerGreg Kroah-Hartman <>2011-03-23 12:50:46 -0700
commit7503dd0d943211e428a91ec35b3e44604b722196 (patch)
parent95abbe32f49a602b77144e797b556ee801be46a1 (diff)
mmc: sdio: remember new card RCA when redetecting card
commit 0aab3995485b8a994bf29a995a008c9ea4a28054 upstream. During redetection of a SDIO card, a request for a new card RCA was submitted to the card, but was then overwritten by the old RCA. This caused the card to be deselected instead of selected when using the incorrect RCA. This bug's been present since the "oldcard" handling was introduced in 2.6.32. Signed-off-by: Stefan Nilsson XK <> Reviewed-by: Ulf Hansson <> Reviewed-by: Pawel Wieczorkiewicz <> Signed-off-by: Linus Walleij <> Signed-off-by: Chris Ball <> Signed-off-by: Greg Kroah-Hartman <>
1 files changed, 8 insertions, 0 deletions
diff --git a/drivers/mmc/core/sdio.c b/drivers/mmc/core/sdio.c
index efef5f94ac42..47c7461dd4be 100644
--- a/drivers/mmc/core/sdio.c
+++ b/drivers/mmc/core/sdio.c
@@ -395,6 +395,14 @@ static int mmc_sdio_init_card(struct mmc_host *host, u32 ocr,
if (err)
goto remove;
+ /*
+ * Update oldcard with the new RCA received from the SDIO
+ * device -- we're doing this so that it's updated in the
+ * "card" struct when oldcard overwrites that later.
+ */
+ if (oldcard)
+ oldcard->rca = card->rca;
mmc_set_bus_mode(host, MMC_BUSMODE_PUSHPULL);