summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSalva Peiró <speiro@ai2.upv.es>2013-10-11 12:50:03 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2013-11-04 04:23:41 -0800
commitdf290b8ea8c8b3305a3b3a4eb36ec1d2d79570de (patch)
tree0861d816fb9e7af3bab2a1f4310389fe2799a804
parent120bc4f8543d6928337054fa15a23fda3cd63fe7 (diff)
farsync: fix info leak in ioctl
[ Upstream commit 96b340406724d87e4621284ebac5e059d67b2194 ] The fst_get_iface() code fails to initialize the two padding bytes of struct sync_serial_settings after the ->loopback member. Add an explicit memset(0) before filling the structure to avoid the info leak. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/net/wan/farsync.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/wan/farsync.c b/drivers/net/wan/farsync.c
index 1a623183cbe5..3710427c3fe1 100644
--- a/drivers/net/wan/farsync.c
+++ b/drivers/net/wan/farsync.c
@@ -1972,6 +1972,7 @@ fst_get_iface(struct fst_card_info *card, struct fst_port_info *port,
}
i = port->index;
+ memset(&sync, 0, sizeof(sync));
sync.clock_rate = FST_RDL(card, portConfig[i].lineSpeed);
/* Lucky card and linux use same encoding here */
sync.clock_type = FST_RDB(card, portConfig[i].internalClock) ==