summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBian Yu <bianyu@kedacom.com>2012-12-12 22:26:58 -0500
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2013-01-27 20:48:59 -0800
commit8d218e347dce06af65d1bc6da4d4c59d2a5c9a24 (patch)
tree4fef18bcbbc0c2e0c014fa5376f9f5ee22e2b44c
parent5afeb70e606bdce5a76de1b482c53ad3b2829bf4 (diff)
libata: ahci: Fix lack of command retry after a success error handler.
commit 1eaca39a84170b369fe61fb1da3c1e8606859e99 upstream. It should be a mistake introduced by commit 8d899e70c1b3afff. qc->flags can't be set AC_ERR_* Signed-off-by: Bian Yu <bianyu@kedacom.com> Signed-off-by: Jeff Garzik <jgarzik@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/ata/libata-eh.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
index bf039b0e97b7..bcf4437214f5 100644
--- a/drivers/ata/libata-eh.c
+++ b/drivers/ata/libata-eh.c
@@ -2094,7 +2094,7 @@ static unsigned int ata_eh_speed_down(struct ata_device *dev,
*/
static inline int ata_eh_worth_retry(struct ata_queued_cmd *qc)
{
- if (qc->flags & AC_ERR_MEDIA)
+ if (qc->err_mask & AC_ERR_MEDIA)
return 0; /* don't retry media errors */
if (qc->flags & ATA_QCFLAG_IO)
return 1; /* otherwise retry anything from fs stack */