diff options
| author | Liu Ying <victor.liu@nxp.com> | 2019-03-26 13:36:52 +0800 |
|---|---|---|
| committer | Liu Ying <victor.liu@nxp.com> | 2019-03-28 09:50:42 +0800 |
| commit | a8452e16eb506d64702c6648af4e910a01806948 (patch) | |
| tree | 9db8b309262a324f35efbb72effecf79d260c6b3 | |
| parent | f6714f0e5ab64ebfb32fee00c84e058ca19103f8 (diff) | |
MLK-20208-1 mxc IPUv3: device: Remove a piece of dead code in ipu_task_thread()
The check on !sp_tsk0 is unnecessary in ipu_task_thread(), because the
beforehand "list_del(&sp_tsk0->node);" within the context implies sp_tsk0
is not null, otherwise, we'll dereference a null pointer earlier.
Detected by CoverityScan, CID#17842 ("Logically dead code")
Signed-off-by: Liu Ying <victor.liu@nxp.com>
(cherry picked from commit 9ad5edd076d61bc8bb3a558e523cc7b31f2c3043)
| -rw-r--r-- | drivers/mxc/ipu3/ipu_device.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/mxc/ipu3/ipu_device.c b/drivers/mxc/ipu3/ipu_device.c index 38fe39787fc0..aceb5300b1fc 100644 --- a/drivers/mxc/ipu3/ipu_device.c +++ b/drivers/mxc/ipu3/ipu_device.c @@ -1,5 +1,6 @@ /* * Copyright 2005-2015 Freescale Semiconductor, Inc. All Rights Reserved. + * Copyright 2019 NXP */ /* @@ -3301,10 +3302,6 @@ static int ipu_task_thread(void *argv) /* let the parent thread do the first sp_task */ /* FIXME: ensure the correct sequence for split 4size: 5/6->9/a*/ - if (!sp_tsk0) - dev_err(tsk->dev, - "ERR: no-0x%x,can not get split_tsk0\n", - tsk->task_no); wake_up_interruptible(&thread_waitq); get_res_do_task(sp_tsk0); dev_dbg(sp_tsk0->dev, |