diff options
| author | Davide Caratti <dcaratti@redhat.com> | 2019-03-20 15:00:15 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-05-04 09:15:20 +0200 |
| commit | d2e7387e5128e2182a90e82ff36a5dab4cd0c1bc (patch) | |
| tree | 23c3ad2e0b26239f951ae9509829616bf40049c6 /arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi | |
| parent | 670588f2eb0f9f8ada16d834935bd535c31f482b (diff) | |
net/sched: don't dereference a->goto_chain to read the chain index
[ Upstream commit fe384e2fa36ca084a456fd30558cccc75b4b3fbd ]
callers of tcf_gact_goto_chain_index() can potentially read an old value
of the chain index, or even dereference a NULL 'goto_chain' pointer,
because 'goto_chain' and 'tcfa_action' are read in the traffic path
without caring of concurrent write in the control path. The most recent
value of chain index can be read also from a->tcfa_action (it's encoded
there together with TC_ACT_GOTO_CHAIN bits), so we don't really need to
dereference 'goto_chain': just read the chain id from the control action.
Fixes: e457d86ada27 ("net: sched: add couple of goto_chain helpers")
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin (Microsoft) <sashal@kernel.org>
Diffstat (limited to 'arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi')
0 files changed, 0 insertions, 0 deletions