diff options
| author | Anna-Maria Gleixner <anna-maria@linutronix.de> | 2016-07-13 17:16:32 +0000 |
|---|---|---|
| committer | Ingo Molnar <mingo@kernel.org> | 2016-07-15 10:40:21 +0200 |
| commit | 162e52a117af5d9c5dfc62b7c2ee90b3e91a7b32 (patch) | |
| tree | d0fde3d1c08172cc0bce1e4ed158fe66b3e8fa05 /arch/x86/kvm/x86.c | |
| parent | 48d7f6c715782a6f6d4a5535f1233b764ce6b6f2 (diff) | |
KVM/x86: Remove superfluous SMP function call
Since the following commit:
1cf4f629d9d2 ("cpu/hotplug: Move online calls to hotplugged cpu")
... the CPU_ONLINE and CPU_DOWN_PREPARE notifiers are always run on the hot
plugged CPU, and as of commit:
3b9d6da67e11 ("cpu/hotplug: Fix rollback during error-out in __cpu_disable()")
the CPU_DOWN_FAILED notifier also runs on the hot plugged CPU. This patch
converts the SMP functional calls into direct calls.
smp_function_call_single() executes the function with interrupts
disabled. This calling convention is not preserved because there
is no reason to do so.
Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Radim Krcmar <rkrcmar@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: kvm@vger.kernel.org
Cc: rt@linutronix.de
Link: http://lkml.kernel.org/r/20160713153335.452527104@linutronix.de
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'arch/x86/kvm/x86.c')
| -rw-r--r-- | arch/x86/kvm/x86.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 7da5dd2057a9..6f90595fdd64 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -5662,15 +5662,13 @@ static struct notifier_block kvmclock_cpufreq_notifier_block = { static int kvmclock_cpu_notifier(struct notifier_block *nfb, unsigned long action, void *hcpu) { - unsigned int cpu = (unsigned long)hcpu; - switch (action) { case CPU_ONLINE: case CPU_DOWN_FAILED: - smp_call_function_single(cpu, tsc_khz_changed, NULL, 1); + tsc_khz_changed(NULL); break; case CPU_DOWN_PREPARE: - smp_call_function_single(cpu, tsc_bad, NULL, 1); + tsc_bad(NULL); break; } return NOTIFY_OK; |