diff options
author | Dave Chinner <dchinner@redhat.com> | 2012-11-28 13:01:02 +1100 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-01-11 09:18:53 -0800 |
commit | f8b723cc9f1a9eec83c8527d67eedc6249b7fb66 (patch) | |
tree | 19eecb7f9b2e5a377ad21f87b3c425c6471859bb /arch | |
parent | 82251473514fde36ce8dc0167f41eaf7ef6a4cb9 (diff) |
xfs: fix stray dquot unlock when reclaiming dquots
commit b870553cdecb26d5291af09602352b763e323df2 upstream.
When we fail to get a dquot lock during reclaim, we jump to an error
handler that unlocks the dquot. This is wrong as we didn't lock the
dquot, and unlocking it means who-ever is holding the lock has had
it silently taken away, and hence it results in a lock imbalance.
Found by inspection while modifying the code for the numa-lru
patchset. This fixes a random hang I've been seeing on xfstest 232
for the past several months.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Ben Myers <bpm@sgi.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'arch')
0 files changed, 0 insertions, 0 deletions