summaryrefslogtreecommitdiff
path: root/arch
diff options
context:
space:
mode:
authorAlan Cox <alan@linux.intel.com>2012-07-25 16:28:19 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2012-08-15 12:04:11 -0700
commit7b1cad628030b9bbdaaa4bb8ff73cabaab6e82c9 (patch)
tree0df03d65b4687cd9a3f3a0f2ee1430428003ee04 /arch
parent61e0a9e79d85258d254c5bfb7832c40ba2c46ed4 (diff)
x86, nops: Missing break resulting in incorrect selection on Intel
commit d6250a3f12edb3a86db9598ffeca3de8b4a219e9 upstream. The Intel case falls through into the generic case which then changes the values. For cases like the P6 it doesn't do the right thing so this seems to be a screwup. Signed-off-by: Alan Cox <alan@linux.intel.com> Link: http://lkml.kernel.org/n/tip-lww2uirad4skzjlmrm0vru8o@git.kernel.org Signed-off-by: H. Peter Anvin <hpa@zytor.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'arch')
-rw-r--r--arch/x86/kernel/alternative.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/x86/kernel/alternative.c b/arch/x86/kernel/alternative.c
index a81f2d52f869..dfabea4de417 100644
--- a/arch/x86/kernel/alternative.c
+++ b/arch/x86/kernel/alternative.c
@@ -220,7 +220,7 @@ void __init arch_init_ideal_nops(void)
ideal_nops = intel_nops;
#endif
}
-
+ break;
default:
#ifdef CONFIG_X86_64
ideal_nops = k8_nops;