diff options
| author | James Bottomley <James.Bottomley@suse.de> | 2011-05-18 16:20:10 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2011-06-03 09:31:42 +0900 |
| commit | 294319fea7169f8a4abb48b1e9b3b98c7334e465 (patch) | |
| tree | 761b6153591b89cc63c2d5a57a8d301e4bb0477a /block | |
| parent | 071f305d6f2ecd2239f148858ead57a2f4fb16d9 (diff) | |
block: add proper state guards to __elv_next_request
commit 0a58e077eb600d1efd7e54ad9926a75a39d7f8ae upstream.
blk_cleanup_queue() calls elevator_exit() and after this, we can't
touch the elevator without oopsing. __elv_next_request() must check
for this state because in the refcounted queue model, we can still
call it after blk_cleanup_queue() has been called.
This was reported as causing an oops attributable to scsi.
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'block')
| -rw-r--r-- | block/blk.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/block/blk.h b/block/blk.h index 1f798b5a6f19..1566e8d5d94e 100644 --- a/block/blk.h +++ b/block/blk.h @@ -81,7 +81,8 @@ static inline struct request *__elv_next_request(struct request_queue *q) q->flush_queue_delayed = 1; return NULL; } - if (!q->elevator->ops->elevator_dispatch_fn(q, 0)) + if (test_bit(QUEUE_FLAG_DEAD, &q->queue_flags) || + !q->elevator->ops->elevator_dispatch_fn(q, 0)) return NULL; } } |