diff options
author | Antonio Ospite <ospite@studenti.unina.it> | 2010-10-05 17:20:17 +0200 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-10-28 21:51:08 -0700 |
commit | cdcaefbcdc06c945dec978a9015f25f86e622844 (patch) | |
tree | 28913914916d8f17d844e744fdc7d8f611d2e25f /drivers/hid | |
parent | dc7237c6b7b529c5da2776cbb8b68cc74d1555c3 (diff) |
HID: hidraw, fix a NULL pointer dereference in hidraw_write
commit e42dee9a99a3ecd32b5c027e8f7411fb5bc11eb6 upstream.
BUG: unable to handle kernel NULL pointer dereference at 0000000000000028
IP: [<ffffffffa0f0a625>] hidraw_write+0x3b/0x116 [hid]
[...]
This is reproducible by disconnecting the device while userspace writes
to dev node in a loop and doesn't check return values in order to exit
the loop.
Signed-off-by: Antonio Ospite <ospite@studenti.unina.it>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/hid')
-rw-r--r-- | drivers/hid/hidraw.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/drivers/hid/hidraw.c b/drivers/hid/hidraw.c index f43e95e11d48..7dca2faacdfa 100644 --- a/drivers/hid/hidraw.c +++ b/drivers/hid/hidraw.c @@ -111,6 +111,12 @@ static ssize_t hidraw_write(struct file *file, const char __user *buffer, size_t int ret = 0; mutex_lock(&minors_lock); + + if (!hidraw_table[minor]) { + ret = -ENODEV; + goto out; + } + dev = hidraw_table[minor]->hid; if (!dev->hid_output_raw_report) { |