diff options
| author | Dima Zavin <dima@android.com> | 2011-10-04 16:58:03 -0700 |
|---|---|---|
| committer | Dan Willemsen <dwillemsen@nvidia.com> | 2011-11-30 21:39:09 -0800 |
| commit | 702e787706791a2edac206f30996bd5c32302e85 (patch) | |
| tree | dfff313da2bf62b95bbdd26fcdb7c2253fd4eb0d /drivers/input | |
| parent | 2eb730802be4d77ca3630fc031f28fe7e8c3be6f (diff) | |
input: evdev: only allow reading events if a full packet is present
Without this, it was possible for the reader to get ahead of packet_head.
If the the input device generated a partial packet *right* after the
reader got ahead, then we can get into a situation where the device is
marked readable but read always returns 0 until the next packet is
finished (i.e a SYN is generated by the input driver).
This situation can also happen if we overflow the buffer while a reader
is trying to read an event out.
Change-Id: If01ab371bc7de1bf1f90c122dcc5a29242b01a09
Signed-off-by: Dima Zavin <dima@android.com>
Diffstat (limited to 'drivers/input')
| -rw-r--r-- | drivers/input/evdev.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/input/evdev.c b/drivers/input/evdev.c index 07b6c8153913..13a741ae6045 100644 --- a/drivers/input/evdev.c +++ b/drivers/input/evdev.c @@ -381,7 +381,7 @@ static int evdev_fetch_next_event(struct evdev_client *client, spin_lock_irq(&client->buffer_lock); - have_event = client->head != client->tail; + have_event = client->packet_head != client->tail; if (have_event) { *event = client->buffer[client->tail++]; client->tail &= client->bufsize - 1; |