diff options
| author | Mihai Serban <mihai.serban@nxp.com> | 2017-08-08 20:41:07 +0300 |
|---|---|---|
| committer | Leonard Crestez <leonard.crestez@nxp.com> | 2018-08-24 12:41:33 +0300 |
| commit | 81da2a65be5783f439a89efd02b99448ad81a3f0 (patch) | |
| tree | 575f9dc0d14d9b7e5b3ef80dddeeb69454ce9755 /drivers/net/wireless/bcmdhd_1363 | |
| parent | c55f8c104929bc4dbeb6a64acdce7f1b9a35f35f (diff) | |
MLK-16163: WiFi: Fix compiler warning in bcmdhd driver
The mode the BUSTYPE macro is defined in
drivers/net/wireless/bcmdhd_1363/include/bcmdefs.h
will always trigger the below compiler warning when BCMBUSTYPE
is not defined.
Keep the comparison semantic but fix the warning by using a different
variable.
drivers/net/wireless/bcmdhd_1363/siutils.c: In function ‘si_doattach’:
drivers/net/wireless/bcmdhd_1363/siutils.c:520:14: warning:
self-comparison always evaluates to false [-Wtautological-compare]
if (bustype != BUSTYPE(bustype)) {
^~
Fixes: b2290481a4f1 ("MLK-16042-1: Add bcmdhd v1.363 PCIE driver")
Signed-off-by: Mihai Serban <mihai.serban@nxp.com>
Reviewed-by: Octavian Purdila <octavian.purdila@nxp.com>
Diffstat (limited to 'drivers/net/wireless/bcmdhd_1363')
| -rw-r--r-- | drivers/net/wireless/bcmdhd_1363/siutils.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/wireless/bcmdhd_1363/siutils.c b/drivers/net/wireless/bcmdhd_1363/siutils.c index 208750f707ea..44f738ff73f3 100644 --- a/drivers/net/wireless/bcmdhd_1363/siutils.c +++ b/drivers/net/wireless/bcmdhd_1363/siutils.c @@ -517,9 +517,9 @@ si_doattach(si_info_t *sii, uint devid, osl_t *osh, void *regs, } sih->bustype = bustype; - if (bustype != BUSTYPE(bustype)) { + if (sih->bustype != BUSTYPE(bustype)) { SI_ERROR(("si_doattach: bus type %d does not match configured bus type %d\n", - bustype, BUSTYPE(bustype))); + sih->bustype, BUSTYPE(bustype))); return NULL; } |