diff options
| author | Michał Mirosław <mirq-linux@rere.qmqm.pl> | 2021-07-26 10:30:56 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-09-03 10:08:14 +0200 |
| commit | 0d4ba693db4884a54e0149ed7768d31256cd7dbb (patch) | |
| tree | a10e45f0dde0399264c01ed953f91d208c45e626 /drivers/opp | |
| parent | baf56a1d8199d7a86ecd43236fa2023335701773 (diff) | |
opp: remove WARN when no valid OPPs remain
[ Upstream commit 335ffab3ef864539e814b9a2903b0ae420c1c067 ]
This WARN can be triggered per-core and the stack trace is not useful.
Replace it with plain dev_err(). Fix a comment while at it.
Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/opp')
| -rw-r--r-- | drivers/opp/of.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/opp/of.c b/drivers/opp/of.c index 249738e1e0b7..603c688fe23d 100644 --- a/drivers/opp/of.c +++ b/drivers/opp/of.c @@ -682,8 +682,9 @@ static int _of_add_opp_table_v2(struct device *dev, struct opp_table *opp_table) } } - /* There should be one of more OPP defined */ - if (WARN_ON(!count)) { + /* There should be one or more OPPs defined */ + if (!count) { + dev_err(dev, "%s: no supported OPPs", __func__); ret = -ENOENT; goto remove_static_opp; } |