diff options
| author | Richard Zhu <hongxing.zhu@nxp.com> | 2018-03-09 13:50:29 +0800 |
|---|---|---|
| committer | Jason Liu <jason.hui.liu@nxp.com> | 2019-02-12 10:30:57 +0800 |
| commit | f1fd3825007f5249ca635e258a651420e1249c75 (patch) | |
| tree | 2cd991649579cf4cd1f40178c9833966b1c2d1b5 /drivers/pci | |
| parent | 850fea3d344b24e4717d1482f8d284a80d88c169 (diff) | |
MLK-11780 PCI: imx: correct some type mistakes
- They should be bitwise logic, not the boolean logic.
- Correct the error return values.
Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
Diffstat (limited to 'drivers/pci')
| -rw-r--r-- | drivers/pci/dwc/pci-imx6.c | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/drivers/pci/dwc/pci-imx6.c b/drivers/pci/dwc/pci-imx6.c index 82d999387527..c19507839740 100644 --- a/drivers/pci/dwc/pci-imx6.c +++ b/drivers/pci/dwc/pci-imx6.c @@ -1992,22 +1992,22 @@ static irqreturn_t imx_pcie_dma_isr(int irq, void *param) /* check write isr */ irqs = readl(pci->dbi_base + offset + DMA_WRITE_INT_STS); - if (irqs && DMA_DONE_INT_STS) { + if (irqs & DMA_DONE_INT_STS) { /* write 1 clear */ - writel(irqs && DMA_DONE_INT_STS, + writel(irqs & DMA_DONE_INT_STS, pci->dbi_base + offset + DMA_WRITE_INT_CLR); dma_w_end = 1; - } else if (irqs && DMA_ABORT_INT_STS) { + } else if (irqs & DMA_ABORT_INT_STS) { pr_info("imx pcie dma write error 0x%0x.\n", irqs); } /* check read isr */ irqs = readl(pci->dbi_base + offset + DMA_READ_INT_STS); - if (irqs && DMA_DONE_INT_STS) { + if (irqs & DMA_DONE_INT_STS) { /* write 1 clear */ - writel(irqs && DMA_DONE_INT_STS, + writel(irqs & DMA_DONE_INT_STS, pci->dbi_base + offset + DMA_READ_INT_CLR); dma_r_end = 1; - } else if (irqs && DMA_ABORT_INT_STS) { + } else if (irqs & DMA_ABORT_INT_STS) { pr_info("imx pcie dma read error 0x%0x.", irqs); } return IRQ_HANDLED; @@ -2473,14 +2473,14 @@ static int __init imx_pcie_probe(struct platform_device *pdev) test_reg1 = devm_kzalloc(&pdev->dev, test_region_size, GFP_KERNEL); if (!test_reg1) { - ret = PTR_ERR(test_reg1); + ret = -ENOMEM; return ret; } test_reg2 = devm_kzalloc(&pdev->dev, test_region_size, GFP_KERNEL); if (!test_reg2) { - ret = PTR_ERR(test_reg1); + ret = -ENOMEM; return ret; } } @@ -2489,7 +2489,7 @@ static int __init imx_pcie_probe(struct platform_device *pdev) test_region_size); if (!pcie_arb_base_addr) { dev_err(dev, "ioremap error in ep io test\n"); - ret = PTR_ERR(pcie_arb_base_addr); + ret = -ENOMEM; return ret; } |