summaryrefslogtreecommitdiff
path: root/drivers/pinctrl/pinctrl-ab8505.c
diff options
context:
space:
mode:
authorLee Jones <lee.jones@linaro.org>2013-01-31 09:45:17 +0000
committerLinus Walleij <linus.walleij@linaro.org>2013-02-06 22:38:40 +0100
commitb9fab6e45d2d41de5495f7d40808e9e131652f92 (patch)
treed832b21acfd75e63982c6031e5b20998febf760a /drivers/pinctrl/pinctrl-ab8505.c
parentfa1ec996ac1a42e46ec7dca089252f124c81d7bd (diff)
pinctrl/abx500: align GPIO cluster boundaries
Not quite sure how this ever worked. In ab8500_gpio_to_irq() the GPIO for conversion is passed through as the second argument. If GPIO13, which is a valid GPIO for IRQ functionality, was received; it would be rejected by the following guard: GPIO_IRQ_CLUSTER(5, 12, 0); /* GPIO numbers start from 1 */ if (offset >= cluster->start && offset <= cluster->end) /* Valid GPIO for IRQ use */ Signed-off-by: Lee Jones <lee.jones@linaro.org> [Augmented to account for off-by-one problem] Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/pinctrl/pinctrl-ab8505.c')
-rw-r--r--drivers/pinctrl/pinctrl-ab8505.c10
1 files changed, 5 insertions, 5 deletions
diff --git a/drivers/pinctrl/pinctrl-ab8505.c b/drivers/pinctrl/pinctrl-ab8505.c
index 40dc3e107daf..825710afb2e1 100644
--- a/drivers/pinctrl/pinctrl-ab8505.c
+++ b/drivers/pinctrl/pinctrl-ab8505.c
@@ -349,11 +349,11 @@ struct alternate_functions ab8505_alternate_functions[AB8505_GPIO_MAX_NUMBER + 1
* GPIO52 to GPIO53
*/
struct abx500_gpio_irq_cluster ab8505_gpio_irq_cluster[] = {
- GPIO_IRQ_CLUSTER(9, 10, 0), /* GPIO numbers start from 1 */
- GPIO_IRQ_CLUSTER(12, 12, 0),
- GPIO_IRQ_CLUSTER(39, 40, 0),
- GPIO_IRQ_CLUSTER(49, 49, 0),
- GPIO_IRQ_CLUSTER(51, 52, 0),
+ GPIO_IRQ_CLUSTER(10, 11, 0),
+ GPIO_IRQ_CLUSTER(13, 13, 0),
+ GPIO_IRQ_CLUSTER(40, 41, 0),
+ GPIO_IRQ_CLUSTER(50, 50, 0),
+ GPIO_IRQ_CLUSTER(52, 53, 0),
};
static struct abx500_pinctrl_soc_data ab8505_soc = {