diff options
| author | Jonathan Cameron <jic23@cam.ac.uk> | 2011-09-30 10:05:40 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2011-10-03 16:07:04 -0700 |
| commit | 68b41aefa30d9b8713d1c255080863e611a5a226 (patch) | |
| tree | 858ae273725d0b224d00322c0ad927f619e66033 /drivers/staging/iio/adc/ad7606.h | |
| parent | 0b89525dfcb8b90b5992d6de1433aa04b0a04b3a (diff) | |
staging:iio:adc:ad7606 make gpio request failures more consistent
To my mind, if a gpio is specified in the board file, yet fails
to be successfully requested, that is an error condidtion and
the driver should not muddle on regardless.
This does mean unwinding the gpios on error. Also the free_gpios
function is reordered so that it is consistent with the request one
(reverse order obviously).
This patch is the category of not technically fixing anything, just
making the driver be more in line with what a reviewer will expect.
Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/staging/iio/adc/ad7606.h')
| -rw-r--r-- | drivers/staging/iio/adc/ad7606.h | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/drivers/staging/iio/adc/ad7606.h b/drivers/staging/iio/adc/ad7606.h index b8b3d8ef1ff2..8fc259f4b3db 100644 --- a/drivers/staging/iio/adc/ad7606.h +++ b/drivers/staging/iio/adc/ad7606.h @@ -75,11 +75,6 @@ struct ad7606_state { unsigned range; unsigned oversampling; bool done; - bool have_frstdata; - bool have_os; - bool have_stby; - bool have_reset; - bool have_range; void __iomem *base_address; /* |