diff options
| author | Colin Ian King <colin.king@canonical.com> | 2017-03-20 14:08:50 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-03-21 08:36:14 +0100 |
| commit | 35060a228e70c712cb626ef3eabaedc40903eb77 (patch) | |
| tree | c014727b24d6cb2db5479d4ae87a5ab5240432f2 /drivers/staging/vc04_services | |
| parent | c62990801d3beb7e6182c742832128ef3e2b1100 (diff) | |
staging: vc04_services: fix NULL pointer dereference on pointer 'service'
Currently, if pservice is null then service is set to NULL and immediately
afterwards service is dereferenced causing a null pointer dereference. Fix
this by bailing out early of the function with a null return.
Detected by CoverityScan, CID#1419681 ("Explicit null dereferenced")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/vc04_services')
| -rw-r--r-- | drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c index dc9f85c2a5da..4f9e738abddf 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c @@ -2673,7 +2673,7 @@ vchiq_add_service_internal(VCHIQ_STATE_T *state, if (!pservice) { kfree(service); - service = NULL; + return NULL; } service_quota = &state->service_quotas[service->localport]; |