summaryrefslogtreecommitdiff
path: root/drivers/usb
diff options
context:
space:
mode:
authormatthieu castet <castet.matthieu@free.fr>2006-01-18 07:39:27 +0100
committerGreg Kroah-Hartman <gregkh@suse.de>2006-01-31 17:23:41 -0800
commitfdf290fd6d6a17b40055359263ed6003e87cb89b (patch)
tree52d27ebf44609f4d4083596919f3e11395fb5e40 /drivers/usb
parente40abaf6336ef3756277bab70db47a47da4aa325 (diff)
[PATCH] UEAGLE : cmv name bug (was cosmetic)
this patch correct a possible bug with cmv_name being static. If there is 2 modems and the driver is scheduled when filling cmv_name this could result with garbage in cmv_name. We allocate cmv_name on the stack but with a small size in order to avoid that. Signed-off-by: Matthieu CASTET <castet.matthieu@free.fr> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/usb')
-rw-r--r--drivers/usb/atm/ueagle-atm.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/atm/ueagle-atm.c b/drivers/usb/atm/ueagle-atm.c
index b0026ecc6a36..830d2c982670 100644
--- a/drivers/usb/atm/ueagle-atm.c
+++ b/drivers/usb/atm/ueagle-atm.c
@@ -1013,7 +1013,7 @@ static int request_cmvs(struct uea_softc *sc,
int ret, size;
u8 *data;
char *file;
- static char cmv_name[256] = FW_DIR;
+ char cmv_name[FIRMWARE_NAME_MAX]; /* 30 bytes stack variable */
if (cmv_file[sc->modem_index] == NULL) {
if (UEA_CHIP_VERSION(sc) == ADI930)