diff options
| author | Deepak Nibade <dnibade@nvidia.com> | 2013-12-08 15:09:18 +0530 |
|---|---|---|
| committer | Jon Mayo <jmayo@nvidia.com> | 2013-12-13 10:57:33 -0800 |
| commit | 9266a6dd536f75c233f7ad59c5343aaeff0f3c29 (patch) | |
| tree | 98a1524dbc6798d4165d15f50c76c7486a312c38 /drivers/video/tegra/dc/edid.c | |
| parent | 8a5b5e3231eb2fba0129555e7a6e37f3f28eee39 (diff) | |
video: tegra: dc: fix Coverity issues
- fix dereference before NULL check
Coverity id : 24636
- fix unchecked return value
Coverity id : 25027
Coverity id : 25028
Coverity id : 25243
Coverity id : 25244
Bug 1416640
Change-Id: If9e7ff59267cfc39d10f99061162176b4c49a34c
Signed-off-by: Deepak Nibade <dnibade@nvidia.com>
Reviewed-on: http://git-master/r/339693
Reviewed-by: Automatic_Commit_Validation_User
Reviewed-by: Sachin Nikam <snikam@nvidia.com>
Reviewed-by: Sumit Singh <sumsingh@nvidia.com>
GVS: Gerrit_Virtual_Submit
Reviewed-by: Jon Mayo <jmayo@nvidia.com>
Diffstat (limited to 'drivers/video/tegra/dc/edid.c')
| -rw-r--r-- | drivers/video/tegra/dc/edid.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/drivers/video/tegra/dc/edid.c b/drivers/video/tegra/dc/edid.c index 1a9b76476864..b7ab9a75b5f8 100644 --- a/drivers/video/tegra/dc/edid.c +++ b/drivers/video/tegra/dc/edid.c @@ -208,11 +208,16 @@ int tegra_edid_parse_ext_block(const u8 *raw, int idx, int i; bool basic_audio = false; + if (!edid) { + pr_err("%s: invalid argument\n", __func__); + return -EINVAL; + } + edid->support_audio = 0; ptr = &raw[0]; /* If CEA 861 block get info for eld struct */ - if (edid && ptr) { + if (ptr) { if (*ptr <= 3) edid->eld.eld_ver = 0x02; edid->eld.cea_edid_ver = ptr[1]; |