diff options
author | Stefan Agner <stefan.agner@toradex.com> | 2014-01-22 18:09:13 +0100 |
---|---|---|
committer | Stefan Agner <stefan.agner@toradex.com> | 2014-01-22 18:09:13 +0100 |
commit | f939885e6f77ac92bad278487ccf651f2256a7b0 (patch) | |
tree | 9b01320f84134ca0eafa613c607c67e1cb857852 /drivers/video/tegra/fb.c | |
parent | 3d8f44c100f23574e9a4a9c74fa6054e48ca53c2 (diff) |
video: tegra: updated comments, move front_porch work around
Updated several comments to make code easier to read and understand.
Also use the front_porch workaround in any case, for HDMI output
too.
Diffstat (limited to 'drivers/video/tegra/fb.c')
-rw-r--r-- | drivers/video/tegra/fb.c | 15 |
1 files changed, 13 insertions, 2 deletions
diff --git a/drivers/video/tegra/fb.c b/drivers/video/tegra/fb.c index 90d1363ecf9c..70b82bde9e43 100644 --- a/drivers/video/tegra/fb.c +++ b/drivers/video/tegra/fb.c @@ -125,7 +125,9 @@ static int tegra_fb_set_par(struct fb_info *info) struct tegra_dc_mode mode; - + /* This is usually altered to 16/32 by tegra_fb_check_var + * above which is called before this function + */ switch (var->bits_per_pixel) { case 32: tegra_fb->win->fmt = TEGRA_WIN_FMT_R8G8B8A8; @@ -167,6 +169,7 @@ static int tegra_fb_set_par(struct fb_info *info) return -EINVAL; } + /* Reflect changes on HW */ if (dc->enabled) tegra_dc_disable(dc); tegra_dc_enable(dc); @@ -678,6 +681,12 @@ struct tegra_fb_info *tegra_fb_register(struct nvhost_device *ndev, if (option != NULL) { if (!strcmp(option, "off")) { + /* This off option works perfectly for framebuffer + * device, however the tegra binary driver somehow + * has troubles to handle a missing fb0 when there + * (then, dc1 gets remapped to fb0, which seems + * to be an issue for the binary driver)... + */ ret = -ENODEV; goto err_iounmap_fb; } @@ -687,7 +696,9 @@ struct tegra_fb_info *tegra_fb_register(struct nvhost_device *ndev, } } - /* activate current settings.. */ + /* Activate current settings (tegra_fb_find_mode has call + * tegra_fb_check_var already) + */ if (fb_mem) tegra_fb_set_par(info); |