summaryrefslogtreecommitdiff
path: root/drivers/xen
diff options
context:
space:
mode:
authorNicolas Kaiser <nikai@nikai.net>2011-03-30 21:14:26 +0200
committerKonrad Rzeszutek Wilk <konrad.wilk@oracle.com>2011-03-30 15:37:04 -0400
commit361ae8cb57ec35ace2fa5f9695dba14eca9893e0 (patch)
tree2a2a2dac4ad8abbe701e4c475bd6e6470ea243bd /drivers/xen
parent0ce790e7d736cedc563e1fb4e998babf5a4dbc3d (diff)
xen: events: fix error checks in bind_*_to_irqhandler()
Checking 'irq < 0' doesn't work when 'irq' is unsigned. The assigned bind_evtchn_to_irq() and bind_virq_to_irq() return int, so using int appears appropriate. Signed-off-by: Nicolas Kaiser <nikai@nikai.net> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Diffstat (limited to 'drivers/xen')
-rw-r--r--drivers/xen/events.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/xen/events.c b/drivers/xen/events.c
index 036343ba204e..589f0a53a604 100644
--- a/drivers/xen/events.c
+++ b/drivers/xen/events.c
@@ -912,8 +912,7 @@ int bind_evtchn_to_irqhandler(unsigned int evtchn,
unsigned long irqflags,
const char *devname, void *dev_id)
{
- unsigned int irq;
- int retval;
+ int irq, retval;
irq = bind_evtchn_to_irq(evtchn);
if (irq < 0)
@@ -955,8 +954,7 @@ int bind_virq_to_irqhandler(unsigned int virq, unsigned int cpu,
irq_handler_t handler,
unsigned long irqflags, const char *devname, void *dev_id)
{
- unsigned int irq;
- int retval;
+ int irq, retval;
irq = bind_virq_to_irq(virq, cpu);
if (irq < 0)