diff options
author | Nicholas Mc Guire <hofrat@osadl.org> | 2015-06-07 11:34:40 -0300 |
---|---|---|
committer | Sasha Levin <sasha.levin@oracle.com> | 2015-12-03 09:58:18 -0500 |
commit | 84107ed7c5fd0b03c3b4e5e4bc2fcb5713046b1f (patch) | |
tree | 0383eabd8cb136f34798eff7857909268dc55646 /drivers | |
parent | 7a278b4cf6ac127e76bb14746cf45015eefb6b69 (diff) |
[media] gscpa_m5602: use msecs_to_jiffies for conversions
[ Upstream commit 63f2f417526fc54191f2b813f72dc1d5322bede8 ]
API compliance scanning with coccinelle flagged:
./drivers/media/usb/gspca/m5602/m5602_s5k83a.c:180:9-25:
WARNING: timeout (100) seems HZ dependent
Numeric constants passed to schedule_timeout() make the effective
timeout HZ dependent which makes little sense in a polling loop for
the cameras rotation state.
Fixed up by converting the constant to jiffies with msecs_to_jiffies()
Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/media/usb/gspca/m5602/m5602_s5k83a.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/media/usb/gspca/m5602/m5602_s5k83a.c b/drivers/media/usb/gspca/m5602/m5602_s5k83a.c index 7cbc3a00bda8..bf6b215438e3 100644 --- a/drivers/media/usb/gspca/m5602/m5602_s5k83a.c +++ b/drivers/media/usb/gspca/m5602/m5602_s5k83a.c @@ -177,7 +177,7 @@ static int rotation_thread_function(void *data) __s32 vflip, hflip; set_current_state(TASK_INTERRUPTIBLE); - while (!schedule_timeout(100)) { + while (!schedule_timeout(msecs_to_jiffies(100))) { if (mutex_lock_interruptible(&sd->gspca_dev.usb_lock)) break; |