diff options
author | Jan Kara <jack@suse.cz> | 2011-12-18 17:37:02 -0500 |
---|---|---|
committer | Willy Tarreau <w@1wt.eu> | 2012-10-07 23:37:51 +0200 |
commit | 1f2e32346f7d082246d96e4cedbd54b8739b8ea0 (patch) | |
tree | 2370306998ad23066797fcdedb3e3176f584f4b3 /fs/ext4 | |
parent | ba57e38b830f274138a0349c4aef75d4c75e95a0 (diff) |
ext4: fix error handling on inode bitmap corruption
commit acd6ad83517639e8f09a8c5525b1dccd81cd2a10 upstream.
When insert_inode_locked() fails in ext4_new_inode() it most likely means inode
bitmap got corrupted and we allocated again inode which is already in use. Also
doing unlock_new_inode() during error recovery is wrong since the inode does
not have I_NEW set. Fix the problem by jumping to fail: (instead of fail_drop:)
which declares filesystem error and does not call unlock_new_inode().
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Willy Tarreau <w@1wt.eu>
Diffstat (limited to 'fs/ext4')
-rw-r--r-- | fs/ext4/ialloc.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c index 55a93f5bb003..29d9055b0a73 100644 --- a/fs/ext4/ialloc.c +++ b/fs/ext4/ialloc.c @@ -1015,8 +1015,12 @@ got: if (IS_DIRSYNC(inode)) ext4_handle_sync(handle); if (insert_inode_locked(inode) < 0) { - err = -EINVAL; - goto fail_drop; + /* + * Likely a bitmap corruption causing inode to be allocated + * twice. + */ + err = -EIO; + goto fail; } spin_lock(&sbi->s_next_gen_lock); inode->i_generation = sbi->s_next_generation++; |