summaryrefslogtreecommitdiff
path: root/fs
diff options
context:
space:
mode:
authorNikanth Karthikesan <knikanth@suse.de>2010-05-16 14:00:00 -0400
committerGreg Kroah-Hartman <gregkh@suse.de>2011-03-21 12:44:13 -0700
commitb87c9ea0ff8b0f8e7ff538e1d47a20933b229403 (patch)
treedb271218157276844515488b6b818d57b41b2bac /fs
parent110e9fc4b1c8096f7805c6c3e9e20b55a4aaffc7 (diff)
ext4: Prevent creation of files larger than RLIMIT_FSIZE using fallocate
commit 6d19c42b7cf81c39632b6d4dbc514e8449bcd346 upstream. Currently using posix_fallocate one can bypass an RLIMIT_FSIZE limit and create a file larger than the limit. Add a check for that. Signed-off-by: Nikanth Karthikesan <knikanth@suse.de> Signed-off-by: Amit Arora <aarora@in.ibm.com> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'fs')
-rw-r--r--fs/ext4/extents.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 1667fac41f32..505a28177b8d 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -3545,6 +3545,11 @@ long ext4_fallocate(struct inode *inode, int mode, loff_t offset, loff_t len)
*/
credits = ext4_chunk_trans_blocks(inode, max_blocks);
mutex_lock(&inode->i_mutex);
+ ret = inode_newsize_ok(inode, (len + offset));
+ if (ret) {
+ mutex_unlock(&inode->i_mutex);
+ return ret;
+ }
retry:
while (ret >= 0 && ret < max_blocks) {
block = block + ret;