diff options
| author | Thomas Gleixner <tglx@linutronix.de> | 2009-07-19 08:44:27 -0500 |
|---|---|---|
| committer | Clark Williams <williams@redhat.com> | 2012-04-13 11:01:44 -0500 |
| commit | b6e11e4b86a0357ee527e5964730cba4a9b90725 (patch) | |
| tree | 08035625e5f03f337165e93b0d1f5b0d865bca56 /fs | |
| parent | e16bf852194b3ade1f7dd4c7f18ffdc492913852 (diff) | |
fs: namespace preemption fix
On RT we cannot loop with preemption disabled here as
mnt_make_readonly() might have been preempted. We can safely enable
preemption while waiting for MNT_WRITE_HOLD to be cleared. Safe on !RT
as well.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/namespace.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/fs/namespace.c b/fs/namespace.c index e6081996c9a2..7fd098124790 100644 --- a/fs/namespace.c +++ b/fs/namespace.c @@ -313,8 +313,11 @@ int mnt_want_write(struct vfsmount *m) * incremented count after it has set MNT_WRITE_HOLD. */ smp_mb(); - while (mnt->mnt.mnt_flags & MNT_WRITE_HOLD) + while (mnt->mnt.mnt_flags & MNT_WRITE_HOLD) { + preempt_enable(); cpu_relax(); + preempt_disable(); + } /* * After the slowpath clears MNT_WRITE_HOLD, mnt_is_readonly will * be set to match its requirements. So we must not load that until |