diff options
author | Al Viro <viro@zeniv.linux.org.uk> | 2016-02-27 19:17:33 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2016-03-03 15:07:29 -0800 |
commit | 80d18c0026eb6fc9cd9fb5a36540bfaa8a00fb47 (patch) | |
tree | 31af4e41ca672ee1b0bf3463c822eefd56ab6fca /fs | |
parent | f634ac98bd9218feb31868b43f56e7a5999ce98e (diff) |
do_last(): don't let a bogus return value from ->open() et.al. to confuse us
commit c80567c82ae4814a41287618e315a60ecf513be6 upstream.
... into returning a positive to path_openat(), which would interpret that
as "symlink had been encountered" and proceed to corrupt memory, etc.
It can only happen due to a bug in some ->open() instance or in some LSM
hook, etc., so we report any such event *and* make sure it doesn't trick
us into further unpleasantness.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs')
-rw-r--r-- | fs/namei.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/fs/namei.c b/fs/namei.c index c9eb7e84d05f..f26cecbd6e73 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -3210,6 +3210,10 @@ opened: goto exit_fput; } out: + if (unlikely(error > 0)) { + WARN_ON(1); + error = -EINVAL; + } if (got_write) mnt_drop_write(nd->path.mnt); path_put(&save_parent); |