path: root/include/linux/ftrace.h
diff options
authorNamhyung Kim <>2013-06-07 17:01:16 +0800
committerGreg Kroah-Hartman <>2013-06-13 09:45:03 -0700
commit3a22cc7f184b77731816e55662cd12f0c3d24d56 (patch)
treece3612a4ea2ec1ed53d5c98a24b88aa80067129c /include/linux/ftrace.h
parentce840e2f7825bfd240782dc209c2f2b8db514287 (diff)
tracing: Fix possible NULL pointer dereferences
commit 6a76f8c0ab19f215af2a3442870eeb5f0e81998d upstream. Currently set_ftrace_pid and set_graph_function files use seq_lseek for their fops. However seq_open() is called only for FMODE_READ in the fops->open() so that if an user tries to seek one of those file when she open it for writing, it sees NULL seq_file and then panic. It can be easily reproduced with following command: $ cd /sys/kernel/debug/tracing $ echo 1234 | sudo tee -a set_ftrace_pid In this example, GNU coreutils' tee opens the file with fopen(, "a") and then the fopen() internally calls lseek(). Link: Signed-off-by: Namhyung Kim <> Cc: Frederic Weisbecker <> Cc: Ingo Molnar <> Cc: Namhyung Kim <> Signed-off-by: Steven Rostedt <> [ lizf: adjust context ] Signed-off-by: Li Zefan <> Signed-off-by: Greg Kroah-Hartman <>
Diffstat (limited to 'include/linux/ftrace.h')
1 files changed, 1 insertions, 1 deletions
diff --git a/include/linux/ftrace.h b/include/linux/ftrace.h
index 72a6cabb4d5b..8add29129fbc 100644
--- a/include/linux/ftrace.h
+++ b/include/linux/ftrace.h
@@ -299,7 +299,7 @@ ssize_t ftrace_filter_write(struct file *file, const char __user *ubuf,
size_t cnt, loff_t *ppos);
ssize_t ftrace_notrace_write(struct file *file, const char __user *ubuf,
size_t cnt, loff_t *ppos);
-loff_t ftrace_regex_lseek(struct file *file, loff_t offset, int origin);
+loff_t ftrace_filter_lseek(struct file *file, loff_t offset, int origin);
int ftrace_regex_release(struct inode *inode, struct file *file);
void __init