diff options
| author | Thomas Gleixner <tglx@linutronix.de> | 2009-12-09 09:32:03 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-09-20 13:17:57 -0700 |
| commit | 34d1f22e7617964c395c9e6022d8cf718558fcce (patch) | |
| tree | 8726e8ec955b39072e8567b6b598438656fc0d83 /include | |
| parent | 7272e504cb1f35861e59fade3628f047f897afff (diff) | |
sched: Protect sched_rr_get_param() access to task->sched_class
commit dba091b9e3522b9d32fc9975e48d3b69633b45f0 upstream
sched_rr_get_param calls
task->sched_class->get_rr_interval(task) without protection
against a concurrent sched_setscheduler() call which modifies
task->sched_class.
Serialize the access with task_rq_lock(task) and hand the rq
pointer into get_rr_interval() as it's needed at least in the
sched_fair implementation.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Peter Zijlstra <peterz@infradead.org>
LKML-Reference: <alpine.LFD.2.00.0912090930120.3089@localhost.localdomain>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Mike Galbraith <efault@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'include')
| -rw-r--r-- | include/linux/sched.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/include/linux/sched.h b/include/linux/sched.h index cc24bebf8019..6d42a524497c 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h @@ -1114,7 +1114,8 @@ struct sched_class { void (*prio_changed) (struct rq *this_rq, struct task_struct *task, int oldprio, int running); - unsigned int (*get_rr_interval) (struct task_struct *task); + unsigned int (*get_rr_interval) (struct rq *rq, + struct task_struct *task); #ifdef CONFIG_FAIR_GROUP_SCHED void (*moved_group) (struct task_struct *p); |