diff options
| author | Boaz Harrosh <bharrosh@panasas.com> | 2013-11-21 17:58:08 +0200 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2014-04-02 00:58:45 +0100 |
| commit | c99cf525de222205729192b47e2b859096abe03a (patch) | |
| tree | ee8fdfaa8aacc4af2345e5366016d8dcbd1b730e /include | |
| parent | 17c9dc712c75ac71d18a222d3d5b2f9dad5867b4 (diff) | |
ore: Fix wrong math in allocation of per device BIO
commit aad560b7f63b495f48a7232fd086c5913a676e6f upstream.
At IO preparation we calculate the max pages at each device and
allocate a BIO per device of that size. The calculation was wrong
on some unaligned corner cases offset/length combination and would
make prepare return with -ENOMEM. This would be bad for pnfs-objects
that would in that case IO through MDS. And fatal for exofs were it
would fail writes with EIO.
Fix it by doing the proper math, that will work in all cases. (I
ran a test with all possible offset/length combinations this time
round).
Also when reading we do not need to allocate for the parity units
since we jump over them.
Also lower the max_io_length to take into account the parity pages
so not to allocate BIOs bigger than PAGE_SIZE
Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Diffstat (limited to 'include')
| -rw-r--r-- | include/scsi/osd_ore.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/include/scsi/osd_ore.h b/include/scsi/osd_ore.h index f05fa826f89e..47b458c21fed 100644 --- a/include/scsi/osd_ore.h +++ b/include/scsi/osd_ore.h @@ -101,6 +101,7 @@ struct ore_striping_info { unsigned unit_off; unsigned cur_pg; unsigned cur_comp; + unsigned maxdevUnits; }; struct ore_io_state; |