summaryrefslogtreecommitdiff
path: root/kernel
diff options
context:
space:
mode:
authorJohan Hovold <johan@kernel.org>2016-11-01 11:49:56 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2016-11-26 09:54:53 +0100
commit469fcbcb84d809ec05567d51f4fb664b894517e0 (patch)
treea03190f3b5b9f3daab5406662a5f2a8540477472 /kernel
parent680bc27065b9792373c1b7d4491bd58c03757f0d (diff)
PM / sleep: fix device reference leak in test_suspend
commit ceb75787bc75d0a7b88519ab8a68067ac690f55a upstream. Make sure to drop the reference taken by class_find_device() after opening the RTC device. Fixes: 77437fd4e61f (pm: boot time suspend selftest) Signed-off-by: Johan Hovold <johan@kernel.org> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'kernel')
-rw-r--r--kernel/power/suspend_test.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/kernel/power/suspend_test.c b/kernel/power/suspend_test.c
index 084452e34a12..bdff5ed57f10 100644
--- a/kernel/power/suspend_test.c
+++ b/kernel/power/suspend_test.c
@@ -203,8 +203,10 @@ static int __init test_suspend(void)
/* RTCs have initialized by now too ... can we use one? */
dev = class_find_device(rtc_class, NULL, NULL, has_wakealarm);
- if (dev)
+ if (dev) {
rtc = rtc_class_open(dev_name(dev));
+ put_device(dev);
+ }
if (!rtc) {
printk(warn_no_rtc);
return 0;