diff options
| author | Xiaomeng Tong <xiam0nd.tong@gmail.com> | 2022-03-28 11:24:31 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-04-15 14:18:21 +0200 |
| commit | 7a2ba24cee9ad56d749f364a11610e262bba9dbf (patch) | |
| tree | 557ac94aead441e1182be7fe5d076948033a9044 /lib/test_kmod.c | |
| parent | 910a98e5c1e5c8113e4ef179b44bbfe5df9d6a25 (diff) | |
net: dsa: bcm_sf2_cfp: fix an incorrect NULL check on list iterator
[ Upstream commit 6da69b1da130e7d96766042750cd9f902e890eba ]
The bug is here:
return rule;
The list iterator value 'rule' will *always* be set and non-NULL
by list_for_each_entry(), so it is incorrect to assume that the
iterator value will be NULL if the list is empty or no element
is found.
To fix the bug, return 'rule' when found, otherwise return NULL.
Fixes: ae7a5aff783c7 ("net: dsa: bcm_sf2: Keep copy of inserted rules")
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Xiaomeng Tong <xiam0nd.tong@gmail.com>
Link: https://lore.kernel.org/r/20220328032431.22538-1-xiam0nd.tong@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'lib/test_kmod.c')
0 files changed, 0 insertions, 0 deletions