summaryrefslogtreecommitdiff
path: root/lib
diff options
context:
space:
mode:
authorJulia Lawall <julia@diku.dk>2010-08-06 22:58:49 +0200
committerGreg Kroah-Hartman <gregkh@suse.de>2010-08-13 13:27:21 -0700
commitf70877be9442b008ec6b4bce5f10e7a5c61704d1 (patch)
tree8c1fb321af24df0cb69282aacefe32f3fbfb3ac3 /lib
parentc0eb70bb39fb08004120c5f5bc43faa907b5a5cb (diff)
fs/ecryptfs/file.c: introduce missing free
commit ceeab92971e8af05c1e81a4ff2c271124b55bb9b upstream. The comments in the code indicate that file_info should be released if the function fails. This releasing is done at the label out_free, not out. The semantic match that finds this problem is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @r exists@ local idexpression x; statement S; expression E; identifier f,f1,l; position p1,p2; expression *ptr != NULL; @@ x@p1 = kmem_cache_zalloc(...); ... if (x == NULL) S <... when != x when != if (...) { <+...x...+> } ( x->f1 = E | (x->f1 == NULL || ...) | f(...,x->f1,...) ) ...> ( return <+...x...+>; | return@p2 ...; ) @script:python@ p1 << r.p1; p2 << r.p2; @@ print "* file: %s kmem_cache_zalloc %s" % (p1[0].file,p1[0].line) // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Tyler Hicks <tyhicks@linux.vnet.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'lib')
0 files changed, 0 insertions, 0 deletions