diff options
| author | David S. Miller <davem@davemloft.net> | 2012-05-10 22:16:32 -0400 |
|---|---|---|
| committer | Varun Wadekar <vwadekar@nvidia.com> | 2012-05-18 16:08:43 +0530 |
| commit | becf4f845d636b3efbf9f987319b1b0ef8ec9ead (patch) | |
| tree | 0d21aff613c9fc9634603cfee562f5ce3255d272 /net/ipv4 | |
| parent | 3a75f354e952534076f31843427afa1a7bf2b6ab (diff) | |
ipv4: Do not use dead fib_info entries.
Due to RCU lookups and RCU based release, fib_info objects can
be found during lookup which have fi->fib_dead set.
We must ignore these entries, otherwise we risk dereferencing
the parts of the entry which are being torn down.
Reported-by: Yevgen Pronenko <yevgen.pronenko@sonymobile.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4')
| -rw-r--r-- | net/ipv4/fib_trie.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/net/ipv4/fib_trie.c b/net/ipv4/fib_trie.c index bce36f1a37b4..30b88d7b4bd6 100644 --- a/net/ipv4/fib_trie.c +++ b/net/ipv4/fib_trie.c @@ -1370,6 +1370,8 @@ static int check_leaf(struct fib_table *tb, struct trie *t, struct leaf *l, if (fa->fa_tos && fa->fa_tos != flp->flowi4_tos) continue; + if (fi->fib_dead) + continue; if (fa->fa_info->fib_scope < flp->flowi4_scope) continue; fib_alias_accessed(fa); |