summaryrefslogtreecommitdiff
path: root/net/netlink/af_netlink.c
diff options
context:
space:
mode:
authorJohannes Berg <johannes.berg@intel.com>2021-05-17 16:13:35 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2021-06-16 11:34:51 +0200
commit818298d54aa0d7b3baf5635c94ff3b39b48d037f (patch)
treeae495a7b8c73e9f150c5d96feadc706fb86a8abb /net/netlink/af_netlink.c
parent958cb1078ca60d214826fd90a0961a447fade59a (diff)
bonding: init notify_work earlier to avoid uninitialized use
[ Upstream commit 35d96e631860226d5dc4de0fad0a415362ec2457 ] If bond_kobj_init() or later kzalloc() in bond_alloc_slave() fail, then we call kobject_put() on the slave->kobj. This in turn calls the release function slave_kobj_release() which will always try to cancel_delayed_work_sync(&slave->notify_work), which shouldn't be done on an uninitialized work struct. Always initialize the work struct earlier to avoid problems here. Syzbot bisected this down to a completely pointless commit, some fault injection may have been at work here that caused the alloc failure in the first place, which may interact badly with bisect. Reported-by: syzbot+bfda097c12a00c8cae67@syzkaller.appspotmail.com Signed-off-by: Johannes Berg <johannes.berg@intel.com> Acked-by: Jay Vosburgh <jay.vosburgh@canonical.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'net/netlink/af_netlink.c')
0 files changed, 0 insertions, 0 deletions