diff options
| author | Ben Hutchings <bhutchings@solarflare.com> | 2010-06-28 08:44:07 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-08-02 10:20:53 -0700 |
| commit | 81cb675339c33e6cc30c14e367502692a90b9736 (patch) | |
| tree | 81640cb80bca5e64c55e43d11cda3b51dd80fd8f /net | |
| parent | 8ab78dc05e61a6840a041d1a973616e9815dd84c (diff) | |
ethtool: Fix potential kernel buffer overflow in ETHTOOL_GRXCLSRLALL
commit db048b69037e7fa6a7d9e95a1271a50dc08ae233 upstream.
On a 32-bit machine, info.rule_cnt >= 0x40000000 leads to integer
overflow and the buffer may be smaller than needed. Since
ETHTOOL_GRXCLSRLALL is unprivileged, this can presumably be used for at
least denial of service.
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'net')
| -rw-r--r-- | net/core/ethtool.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/net/core/ethtool.c b/net/core/ethtool.c index 4c12ddb5f5ee..2c21f7aef9a2 100644 --- a/net/core/ethtool.c +++ b/net/core/ethtool.c @@ -244,8 +244,9 @@ static int ethtool_get_rxnfc(struct net_device *dev, void __user *useraddr) if (info.cmd == ETHTOOL_GRXCLSRLALL) { if (info.rule_cnt > 0) { - rule_buf = kmalloc(info.rule_cnt * sizeof(u32), - GFP_USER); + if (info.rule_cnt <= KMALLOC_MAX_SIZE / sizeof(u32)) + rule_buf = kmalloc(info.rule_cnt * sizeof(u32), + GFP_USER); if (!rule_buf) return -ENOMEM; } |