summaryrefslogtreecommitdiff
path: root/drivers/staging/iio
AgeCommit message (Collapse)Author
2014-01-22Check null pointers for sysfs callsStefan Agner
When grepping through sysfs, grep tries to read all sysfs files which are available. Some of them lead to error due to null pointers. Therefor check for null pointers before using them.
2013-12-09iio: adc: add STMPE ADC driver using IIO frameworkStefan Agner
This adds an ADC driver for the STMPE device using the industrial input/output interface. The driver supports raw reading of values. The driver depends on the MFD stmpe driver. If the touchscreen block is enabled too, only for of the 8 ADC channels are available.
2013-01-31staging: iio: light: isl29028: appropriately set interrupt flagPreetham Chandru R
set is_int_enable to true only if we register for a irq. Bug 1211260 Change-Id: I603efe721796db70d504da7999e5d7939d45d13a Signed-off-by: Preetham Chandru R <pchandru@nvidia.com> Reviewed-on: http://git-master/r/193047 (cherry picked from commit 8b89b2b64c67d80fcfc29cd4f6a92d4527e70df9) Reviewed-on: http://git-master/r/195844 Reviewed-by: Automatic_Commit_Validation_User GVS: Gerrit_Virtual_Submit Reviewed-by: Winnie Hsu <whsu@nvidia.com> Reviewed-by: Matthew Pedro <mapedro@nvidia.com>
2012-06-18iio: light: fix error handling for LTR558Shridhar Rasal
Change-Id: I34748241728bb0bab1861f8abacffdfe2939740f Signed-off-by: Shridhar Rasal <srasal@nvidia.com> Reviewed-on: http://git-master/r/109158 Reviewed-by: Sachin Nikam <snikam@nvidia.com> Reviewed-by: Automatic_Commit_Validation_User
2012-03-13iio: light: ALS driver for LTR558Sachin Nikam
Adding driver for Ambient Light and Proximity sensor from Lite On Technology. This driver has sysfs interface to get the als and proximity values and enable/disable als and proximity. Bug 901133 Change-Id: Iafa0346d74825a67d94143181922de7a16cc7718 Signed-off-by: Sachin Nikam <snikam@nvidia.com> Reviewed-on: http://git-master/r/83837 Reviewed-by: Darrell Hunt <dhunt@nvidia.com>
2012-03-09staging: iio: magnetometer: ak8975: Retrieve the correct i2c client dataPreetham Chandru
i2c_get_clientdata() returns an object of type struct indio_dev and not of type struct ak8975_data. Bug 946328 Signed-off-by: Preetham Chandru R <pchandru@nvidia.com> Change-Id: I5803306d6a7829cdf822d22f51fdcdb769fbea1d Reviewed-on: http://git-master/r/88329 Reviewed-by: Mursalin Akon <makon@nvidia.com> Reviewed-by: Shashank Sharma <shashanks@nvidia.com> Reviewed-by: Bharat Nihalani <bnihalani@nvidia.com>
2012-02-18staging:iio:magnetometer:ak8975: Fix probe() error-handlingStephen Warren
Fix ak8975_probe() to jump to the appropriate exit labels when an error occurs. With the previous code, some cleanup actions were being skipped for some error conditions. Upstream v3.2 commit ad31d250bf60c8e4c990e8b0daeedbaa2d6884a9 Change-Id: Ib0ef38f154fbcf18604ad283f51f040b5e038c65 Signed-off-by: Stephen Warren <swarren@nvidia.com> Acked-by: Andrew Chew <achew@nvidia.com> Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> Signed-off-by: Dan Willemsen <dwillemsen@nvidia.com> Reviewed-on: http://git-master/r/83532 Reviewed-by: Andrew Chew <achew@nvidia.com> Reviewed-by: Allen Martin <amartin@nvidia.com>
2012-02-18staging:iio:magnetometer:ak8975: Don't assume 0 is an invalid GPIOStephen Warren
gpio_is_valid() is the defined mechanism to determine whether a GPIO is valid. Use this instead of assuming that 0 is an invalid GPIO. Upstream v3.2 commit 7c6c936832a46e86b0fac654923ce5015bdc80ee Change-Id: Ica81b9fa8379db07ca7d23a6c43c6ab742ef09b6 Signed-off-by: Stephen Warren <swarren@nvidia.com> Acked-by: Andrew Chew <achew@nvidia.com> Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> Signed-off-by: Dan Willemsen <dwillemsen@nvidia.com> Reviewed-on: http://git-master/r/83531 Reviewed-by: Andrew Chew <achew@nvidia.com> Reviewed-by: Allen Martin <amartin@nvidia.com>
2012-02-18staging:iio:magnetometer:ak8975 use platform_data to pass the gpio number.Jonathan Cameron
Tegra doesn't have irq_to_gpio() any more, and ak8975 is included in tegra_defconfig. This causes a build failure. Instead, pass the GPIO name through platform data. [swarren: Rewrote commit description when I squashed this with my patch to remove the irq_to_gpio() call] Upstream v3.2 commit f6d838d7fecfd4e59a4ce7bdfb16165add36d26e Change-Id: I6bd269aa8c0ff8165078ff67e4cbcfdde936c20d Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk> Signed-off-by: Stephen Warren <swarren@nvidia.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> Signed-off-by: Dan Willemsen <dwillemsen@nvidia.com> Reviewed-on: http://git-master/r/83530 Reviewed-by: Andrew Chew <achew@nvidia.com> Reviewed-by: Allen Martin <amartin@nvidia.com>
2011-12-22staging: iio: magnetometer: ak8975: set I2c client dataPreetham Chandru
Set i2c client data before we call ak8975_setup() in the probe function because ak8975_setup() is making a call to ak8975_write_data() which in turn calls i2c_get_clientdata(). If this is not done then i2c_get_clientdata() returns NULL pointer. Bug: 918820 Signed-off-by: Preetham Chandru <pchandru@nvidia.com> Change-Id: I36316fb508d196a32b26853c377921175f94dde6 Reviewed-on: http://git-master/r/71775 Reviewed-by: Automatic_Commit_Validation_User Reviewed-by: Sachin Nikam <snikam@nvidia.com> Reviewed-by: Bharat Nihalani <bnihalani@nvidia.com>
2011-11-303.0: update isl29028 with iio changesDan Willemsen
Rebase-Id: R5de165b205927a47ac2d3e1c8cfa916105682e0d
2011-11-30gcov-kernel: Add GCOV_KERNEL := y to MakefilesJuha Tukkinen
These changes have no effect if CONFIG_GCOV_KERNEL is not set in defconfig. It is easier to trigger GCOV for kernel if this patch is in by only setting the before mentioned flag. Change-Id: I8aade309da2da62c4b3889bd84e4123ba8f182da Signed-off-by: Juha Tukkinen <jtukkinen@nvidia.com> Reviewed-on: http://git-master/r/62999 Reviewed-by: Rohan Somvanshi <rsomvanshi@nvidia.com> Tested-by: Rohan Somvanshi <rsomvanshi@nvidia.com> Rebase-Id: R4c238f707f1db600f188ae83426336753992b7be
2011-11-30isl29028: Convert als data to lux unitsKrishna Yarlagadda
Convert als data units from count to lux before reporting Bug 876339 Change-Id: Ie08b38bc1f4dbd22103cdf921435c5cf1fd21ded Reviewed-on: http://git-master/r/39501 (cherry picked from commit 85f6bcb9497b52a1f1b58e6d30ac0387fbfdeaee) Reviewed-on: http://git-master/r/52862 Tested-by: Sachin Nikam <snikam@nvidia.com> Reviewed-by: Bharat Nihalani <bnihalani@nvidia.com> Reviewed-by: Joseph Lehrer <jlehrer@nvidia.com> Tested-by: Joseph Lehrer <jlehrer@nvidia.com> Rebase-Id: Re0d20d362e55df910caf15b3873e7743dbee132d
2011-11-30iio:isl29028: Adding driver for ISL29028Laxman Dewangan
Adding the complete driver for the ISL29028 to get the proximity, ALS and IR sensing. The reading of these data is provided through sysfs interface. Bug 876339 Original-Change-Id: I25661d0ef54e1053ccf47a716c89607ca51a9862 Reviewed-on: http://git-master/r/23155 Change-Id: I14114e30937fb2e5d308b77a76f2c6f634bf907c (cherry picked from commit b441479716b41ac91cc398c803692e5eb005a704) Reviewed-on: http://git-master/r/52594 Tested-by: Sachin Nikam <snikam@nvidia.com> Reviewed-by: Bharat Nihalani <bnihalani@nvidia.com> Reviewed-by: Joseph Lehrer <jlehrer@nvidia.com> Tested-by: Joseph Lehrer <jlehrer@nvidia.com> Rebase-Id: Re9322c535586f4190c8bd24c2135b0487bef8083
2011-08-02Staging: iio: add some unlocks to raw_read() functionsDan Carpenter
This code was cut and pasted in several places. It's missing some unlocks on error. Signed-off-by: Dan Carpenter <error27@gmail.com> Acked-by: Jonathan Cameron <jic23@cam.ac.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-07-18staging:iio:meter:ade7753 should be 16 bit read not 8 bit for mode register.Jonathan Cameron
Build tested only. Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk> Reported-by: Randy Dunlap <rdunlap@xenotime.net> Acked-by: Randy Dunlap <rdunlap@xenotime.net> Acked-by: Michael Hennerich <michael.hennerich@analog.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-07-18staging:iio:kfifo_buf fix double initialization of the ring device structure.Jonathan Cameron
Looks like this moved into the core at somepoint and kfifo buf got left behind. Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-07-18staging:iio:accel:lis3l02dq: fix incorrect pointer passed to spi_set_drvdata.Jonathan Cameron
This mean all sorts of interesting results on driver removal. Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-07-18staging:iio:imu fix missing register table index for some channelsJonathan Cameron
A number of these register indexes were not set or actually wrong. This only effects sysfs reads. Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk> Acked-by: Michael Hennerich <michael.hennerich@analog.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-07-18staging:iio:adc:ad7476: Incorrect pointer into spi_set_drvdata.Jonathan Cameron
Will cause issues only on driver removal. Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-07-08staging:iio:light:isl29018: Convert some of the isl29018 driver to the new ↵Bryan Freed
iio_chan_spec framework. Remove the driver's get_sensor_data() interfaces and replace them with iio_chan_spec channels. This converts 4 files to the new framework. Driver ABI change: The intensity_infrared_raw file is now intensity_ir_raw. Signed-off-by: Bryan Freed <bfreed@chromium.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-07-08staging:iio: Add an iio channel type string to support proximity sensors.Bryan Freed
Add "proximity" to the iio_chan_type_name_spec_shared string list to support proximity sensors. Now this list fully matches the declared iio_chan_type enums. Signed-off-by: Bryan Freed <bfreed@chromium.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-07-08staging:iio: Reorder channel type strings to match the iio.h enums.Bryan Freed
This makes comparison between the iio_chan_type_name_spec_shared strings and the iio_chan_type enums easier. Signed-off-by: Bryan Freed <bfreed@chromium.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-07-08staging:iio:light:isl29018: Fix the "Init of isl29018 fails" failure.Bryan Freed
The I2C clientdata is set to indio_dev instead of chip as of a couple weeks ago. Correct the calls to i2c_get_clientdata() accordingly. Otherwise the driver fails to initialize. Signed-off-by: Bryan Freed <bfreed@chromium.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-07-05Staging: iio: release locks on error pathsDan Carpenter
There are a couple places here where we should have called mutex_unlock() before returning. Signed-off-by: Dan Carpenter <error27@gmail.com> Acked-by: Jonathan Cameron <jic23@cam.ac.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-07-05staging:iio:gyro:adis16260 fix missing num_channels setup.Jonathan Cameron
Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk> Cc: stable <stable@kernel.org> [3.0] Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-07-05staging: iio: light sensor: Add a calibscale file to the isl29018 light ↵Bryan Freed
sensor driver. Defaulting to 1, this gives a way to amplify the lux value before being reduced by the programmed adc_bit shift. Only support whole numbers right now. When this driver is converted to the new IIO_CHAN framework, it will be easy to support the framework's pseudo float. Add illuminance0_calibscale documentation to sysfs-bus-iio-light. Signed-off-by: Bryan Freed <bfreed@chromium.org> Acked-by: Rhyland Klein <rklein@nvidia.com> Acked-by: Jonathan Cameron <jic23@cam.ac.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-07-05Staging: iio: some uninitialized variable bugsDan Carpenter
There were some uninitialized variable warnings in iio. Two of these came from the recent changes to how the private data was allocated in 83f0422dc6a16 "staging:iio:accel:sca3000: allocate state in iio_dev and use iio_priv to access." drivers/staging/iio/accel/sca3000_core.c: In function 'sca3000_probe': drivers/staging/iio/accel/sca3000_core.c:1137:9: warning: 'st' may be used uninitialized in this function drivers/staging/iio/adc/ad7291.c: In function 'ad7291_probe': drivers/staging/iio/adc/ad7291.c:805:15: warning: 'chip' may be used uninitialized in this function drivers/staging/iio/dac/ad5624r_spi.c: In function 'ad5624r_probe': drivers/staging/iio/dac/ad5624r_spi.c:228:24: warning: 'st' may be used uninitialized in this function Signed-off-by: Dan Carpenter <error27@gmail.com> Acked-by: Jonathan Cameron <jic23@cam.ac.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-07-05Merge Linux 3.0-rc6 into staging-nextGreg Kroah-Hartman
This handles the merge conflicts with the drivers/staging/brcm80211/Kconfig file due to changes on the two different branches. Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28iio: light sensor: Add SMBUS support to the tsl2563 driver.Bryan Freed
This is so we can support it on x86 SMBUS adapters. Since i2c adapters which do not provide an smbus_xfer interface fall back to using their I2C master_xfer interface, all the i2c_master_send() calls in this driver are changed to i2c_smbus_*() calls. This will fail on an i2c adapter that implements a proper subset of (SMBUS_BYTE | SMBUS_BYTE_DATA | SMBUS_WORD_DATA), but I do not see that in any of our adapters today. This results in a few wrapper functions that provide little additional functionality, so remove them and call the smbus functions directly from the general driver code. Signed-off-by: Bryan Freed <bfreed@chromium.org> Acked-by: Jonathan Cameron <jic23@cam.ac.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28iio: light sensor: Fix a panic in the tsl2563 driver.Bryan Freed
Add the required read/write_raw functions to the tsl2563_info_no_irq data structure. This structure is used insted of tsl2563_info when the I2C client has no IRQ. The absence of these functions causes a panic when reading or writing the created sysfs files. Signed-off-by: Bryan Freed <bfreed@chromium.org> Acked-by: Jonathan Cameron <jic23@cam.ac.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28iio: light sensor: Fix a panic in the tsl2563 driver.Bryan Freed
Add a wrapper for this driver around the IIO_CHAN() wrapper to make channel parameters more readable. This fixes a panic caused by the info_masks being accidentally passed in as channel2 parameters which easily surpass the size of the iio_modifier_names_light array. Signed-off-by: Bryan Freed <bfreed@chromium.org> Acked-by: Jonathan Cameron <jic23@cam.ac.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28staging:iio: one more fix for IIO_RING_BUFFER not enabled.Jonathan Cameron
Same problem as seen and fixed in adis16204 et al. These were fixed by Randy in: staging: fix more iio builds when IIO_RING_BUFFER is not enabled Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk> Reported-by: Randy Dunlap <randy.dunlap@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28Staging: iio: dereferencing uninitialized variableDan Carpenter
In the error handling, it dereferences "st" before it has been initialized. I also just tidied it up a bit to remove some extra conditions. Signed-off-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28staging: iio light Kconfig fixletmaximilian attems
No point to start comments with '\'. Signed-off-by: maximilian attems <max@stro.at> Acked-by: Jonathan Cameron <jic23@cam.ac.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28iio: dac: New driver for AD5686R, AD5685R, AD5684R Digital to analog convertersMichael Hennerich
New driver for AD5686R, AD5685R, AD5684R Quad channel digital to analog converters Changes since V1: drop header file use strtobool() Fix dev attribute macros Reorder probe() function Signed-off-by: Michael Hennerich <michael.hennerich@analog.com> Acked-by: Jonathan Cameron <jic23@cam.ac.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28iio: industrialio-core: Add IIO_OUT typeMichael Hennerich
Add IIO_OUT type for DAC like devices In case of IIO_OUT make sure the channel device attribute is writable Ideally we add a flag to iio_chan_spec that tells the core that the channel device attribute is writable... Signed-off-by: Michael Hennerich <michael.hennerich@analog.com> Acked-by: Jonathan Cameron <jic23@cam.ac.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28IIO: ADC: New driver for AD7792/AD7793 3 Channel SPI ADCMichael Hennerich
New driver for AD7792/AD7793 3-Channel, Low Noise, Low Power, 16-/24-Bit Sigma-Delta ADC with On-Chip In-Amp and Reference. The AD7792/AD7793 features a dual use data out ready DOUT/RDY output. In order to avoid contentions on the SPI bus, it's necessary to use spi bus locking. The DOUT/RDY output must also be wired to an interrupt capable GPIO. In INDIO_RING_TRIGGERED mode, this driver may block its SPI bus segment for an extended period of time. Changes since V1: Use bool where applicable. Use data buffer that lives in their own cache line. Restructure ad7793_calibrate_all to use an array. Use msleep. Query REG_ID instead of doing a write/read This is a test. Add support for unipolar mode. Drop range attribute in favor of write scale. Add proper locking. Use new validate_trigger callbacks. Use IIO_IN_DIFF for differential channels. Change attribute naming. Use available_scan_masks. Some other miscellaneous cleanup (none functional changes). Signed-off-by: Michael Hennerich <michael.hennerich@analog.com> Acked-by: Jonathan Cameron <jic23@cam.ac.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28staging:iio:accel:kxsd9 replace kmallocs in power_up with use of already ↵anish kumar
allocated buffer. Signed-off-by: anish kumar <anish198519851985@gmail.com> Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28staging: IIO corrected the spelling in iio-trig-gpioanish
Corrected the spelling. Signed-off-by: anish kumar <anish198519851985@gmail.com> Acked-by: Jonathan Cameron <jic23@cam.ac.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28staging:iio:accel:adis16201 general cleanup, move to iio_priv and buffers in ↵Jonathan Cameron
adis16201_state Basically use various new facilities to tidy up. Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk> Acked-by: Michael Hennerich <michael.hennerich@analog.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28staging:iio:light:isl29018: allocate device state with iio_devJonathan Cameron
V2: Actually allocate the space for iio_priv Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28staging:iio:magnetometer:hmc5843: allocate device state with iio_dev.Jonathan Cameron
Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28staging:iio:meter:ade7759: allocate state with iio_devJonathan Cameron
Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk> Acked-by: Michael Hennerich <michael.hennerich@analog.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28staging:iio:magnetometer:ak8975: allocate chip state with iio_dev.Jonathan Cameron
Here the ordering is a little tricky, so to keep changes minimal, a copy of the gpio number is introduced. Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28staging:iio:resolver:ad2s90 general cleanupJonathan Cameron
Very simple driver, so not much to do. Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk> Acked-by: Michael Hennerich <michael.hennerich@analog.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28staging:iio:resolver:ad2s120x cleanup.Jonathan Cameron
I've currently squashed the vel + pos combined attribute. If people need them precisely paired I doubt they will get them from the sysfs interface anyway. If that is a requirement it should come via a buffer implementation. Note this patch leaves the completely non standard interface alone. That will get fixed later. Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk> Acked-by: Michael Hennerich <michael.hennerich@analog.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28staging:iio:resolver:ad2s1210 general driver cleanup.Jonathan Cameron
Note I haven't made any changes to the userspace interface as yet. This is all about cleaning up what was actually there (handling all errors etc). Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk> Acked-by: Michael Hennerich <michael.hennerich@analog.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28staging:iio:meter:ade7854: Allocate buffers in state and state with iio_dev.Jonathan Cameron
Requires moving a few things around, but should be no functional changes. Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk> Acked-by: Michael Hennerich <michael.hennerich@analog.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28staging:iio:meter:ade7754: allocate state with iio_dev and buffers in state.Jonathan Cameron
Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk> Acked-by: Michael Hennerich <michael.hennerich@analog.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>