From 255189a700d809000157d5eed1a3ede9e6426f68 Mon Sep 17 00:00:00 2001 From: Hugh Dickins Date: Sun, 28 Oct 2007 22:22:25 +0100 Subject: hugetlb: fix error return for brk() entering a hugepage region The lats commit causes the wrong return value. is_hugepage_only_range() is a boolean, so we should return -EINVAL rather than 1. Also - we can use "mm" instead of looking up "current->mm" again. Signed-off-by: Hugh Dickins Signed-off-by: Adrian Bunk --- mm/mmap.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/mm/mmap.c b/mm/mmap.c index a04576de3254..666932b09ea0 100644 --- a/mm/mmap.c +++ b/mm/mmap.c @@ -1870,9 +1870,8 @@ unsigned long do_brk(unsigned long addr, unsigned long len) if ((addr + len) > TASK_SIZE || (addr + len) < addr) return -EINVAL; - error = is_hugepage_only_range(current->mm, addr, len); - if (error) - return error; + if (is_hugepage_only_range(mm, addr, len)) + return -EINVAL; flags = VM_DATA_DEFAULT_FLAGS | VM_ACCOUNT | mm->def_flags; -- cgit v1.2.3