From 14067ff536286bd2f7f79d46337d2228b12ef880 Mon Sep 17 00:00:00 2001 From: Linus Torvalds Date: Mon, 25 Jul 2011 19:55:52 -0700 Subject: vfs: make gcc generate more obvious code for acl permission checking The "fsuid is the inode owner" case is not necessarily always the likely case, but it's the case that doesn't do anything odd and that we want in straight-line code. Make gcc not generate random "jump around for the fun of it" code. This just helps me read profiles. That thing is one of the hottest parts of the whole pathname lookup. Signed-off-by: Linus Torvalds --- fs/namei.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'fs/namei.c') diff --git a/fs/namei.c b/fs/namei.c index ec2e5656b444..ef00b984fb20 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -235,7 +235,7 @@ static int acl_permission_check(struct inode *inode, int mask) if (current_user_ns() != inode_userns(inode)) goto other_perms; - if (current_fsuid() == inode->i_uid) + if (likely(current_fsuid() == inode->i_uid)) mode >>= 6; else { if (IS_POSIXACL(inode) && (mode & S_IRWXG)) { -- cgit v1.2.3