From 5f6e59ae8277cef221fdbf9b12f0c4f80db59944 Mon Sep 17 00:00:00 2001 From: Andreas Gruenbacher Date: Thu, 29 Sep 2016 17:48:40 +0200 Subject: vfs: Use IOP_XATTR flag for bad-inode handling With this change, all the xattr handler based operations will produce an -EIO result for bad inodes, and we no longer only depend on inode->i_op to be set to bad_inode_ops. Signed-off-by: Andreas Gruenbacher Signed-off-by: Al Viro --- fs/xattr.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) (limited to 'fs/xattr.c') diff --git a/fs/xattr.c b/fs/xattr.c index 38b52a356d1b..1f5d0b48422a 100644 --- a/fs/xattr.c +++ b/fs/xattr.c @@ -58,8 +58,11 @@ xattr_resolve_name(struct inode *inode, const char **name) const struct xattr_handler **handlers = inode->i_sb->s_xattr; const struct xattr_handler *handler; - if (!(inode->i_opflags & IOP_XATTR)) + if (!(inode->i_opflags & IOP_XATTR)) { + if (unlikely(is_bad_inode(inode))) + return ERR_PTR(-EIO); return ERR_PTR(-EOPNOTSUPP); + } for_each_xattr_handler(handlers, handler) { const char *n; @@ -168,6 +171,9 @@ int __vfs_setxattr_noperm(struct dentry *dentry, const char *name, } } else if (issec) { const char *suffix = name + XATTR_SECURITY_PREFIX_LEN; + + if (unlikely(is_bad_inode(inode))) + return -EIO; error = security_inode_setsecurity(inode, suffix, value, size, flags); if (!error) -- cgit v1.2.3