From 01b047cbb5e326fb3980bb6fc5206a82ea401170 Mon Sep 17 00:00:00 2001 From: Lyon Wang Date: Wed, 14 Oct 2015 14:15:11 +0800 Subject: [PATCH 1/7] handle base parse error There is no need to send GST_ELEMENT_ERROR becuase ohter tracks may still good to play. no need to end the element, just print error message is enough Upstream-Status: Submitted [https://bugzilla.gnome.org/show_bug.cgi?id=741542] Signed-off-by: Lyon Wang --- libs/gst/base/gstbaseparse.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libs/gst/base/gstbaseparse.c b/libs/gst/base/gstbaseparse.c index df67dd0..2f45d23 100644 --- a/libs/gst/base/gstbaseparse.c +++ b/libs/gst/base/gstbaseparse.c @@ -1324,8 +1324,9 @@ gst_base_parse_sink_event_default (GstBaseParse * parse, GstEvent * event) /* If we STILL have zero frames processed, fire an error */ if (parse->priv->framecount == 0 && !parse->priv->saw_gaps && !parse->priv->first_buffer) { - GST_ELEMENT_ERROR (parse, STREAM, WRONG_TYPE, - ("No valid frames found before end of stream"), (NULL)); + /* GST_ELEMENT_ERROR (parse, STREAM, WRONG_TYPE, + ("No valid frames found before end of stream"), (NULL));*/ + GST_ERROR_OBJECT(parse, "No valid frames decoded before end of stream"); } if (!parse->priv->saw_gaps -- 1.9.1