diff options
| author | Marcel Ziswiler <marcel.ziswiler@toradex.com> | 2020-11-19 12:12:45 +0100 |
|---|---|---|
| committer | Andrejs Cainikovs <andrejs.cainikovs@toradex.com> | 2022-07-20 14:56:48 +0200 |
| commit | c95e406d28d811de32e14e101cf7c13f95ec51fb (patch) | |
| tree | 0f74f31cf356b7c67b2f8c17a11675586e180d22 | |
| parent | 40f30ddbda5c99eabf9f2760fc12ee630700f24b (diff) | |
fastboot: fix build warnings
Fix the following annoying build warnings:
drivers/fastboot/fb_fsl/fb_fsl_common.c: In function ‘fastboot_setup’:
drivers/fastboot/fb_fsl/fb_fsl_common.c:359:2: warning: ‘serialnr.high’ is used uninitialized in this function [-Wuninitialized]
359 | sprintf(serial, "%08x%08x", serialnr.high, serialnr.low);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/fastboot/fb_fsl/fb_fsl_common.c:359:2: warning: ‘serialnr.low’ is used uninitialized in this function [-Wuninitialized]
drivers/fastboot/fb_fsl/fb_fsl_getvar.c:117:13: warning: ‘serial’ defined but not used [-Wunused-variable]
117 | static char serial[IMX_SERIAL_LEN];
| ^~~~~~
Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
(cherry picked from commit f2c35562c77c0d224417199a44a128d831b027e5)
| -rw-r--r-- | drivers/fastboot/fb_fsl/fb_fsl_common.c | 5 | ||||
| -rw-r--r-- | drivers/fastboot/fb_fsl/fb_fsl_getvar.c | 2 |
2 files changed, 6 insertions, 1 deletions
diff --git a/drivers/fastboot/fb_fsl/fb_fsl_common.c b/drivers/fastboot/fb_fsl/fb_fsl_common.c index 636a23f2fb..613b074022 100644 --- a/drivers/fastboot/fb_fsl/fb_fsl_common.c +++ b/drivers/fastboot/fb_fsl/fb_fsl_common.c @@ -365,7 +365,10 @@ static int _fastboot_setup_dev(int *switched) void fastboot_setup(void) { int sw, ret; - struct tag_serialnr serialnr; + struct tag_serialnr serialnr = { + .high = 0, + .low = 0, + }; char serial[17]; if (!env_get("serial#")) { diff --git a/drivers/fastboot/fb_fsl/fb_fsl_getvar.c b/drivers/fastboot/fb_fsl/fb_fsl_getvar.c index 49caf3d7eb..6970904528 100644 --- a/drivers/fastboot/fb_fsl/fb_fsl_getvar.c +++ b/drivers/fastboot/fb_fsl/fb_fsl_getvar.c @@ -118,7 +118,9 @@ static bool is_slotvar(char *cmd) return false; } +#ifdef CONFIG_SERIAL_TAG static char serial[IMX_SERIAL_LEN]; +#endif char *get_serial(void) { |