diff options
| author | Marek Behún <marek.behun@nic.cz> | 2018-07-04 20:23:01 +0200 |
|---|---|---|
| committer | Tom Rini <trini@konsulko.com> | 2018-07-20 15:37:44 -0400 |
| commit | f8c173b6a0b7695089d5ec48cb5b320863c91fdf (patch) | |
| tree | 0a3506445bea0ed84db77e574a2901d45a5d5d83 /fs/btrfs | |
| parent | 25dabd730a534a93b585fe6623783e034399c68e (diff) | |
fs: btrfs: Fix wrong comparison in logical to physical mapping
The comparison
logical > item->logical + item->length
in btrfs_map_logical_to_physical is wrong and should be instead
logical >= item->logical + item->length
For example, if
item->logical = 4096
item->length = 4096
and we are looking for logical = 8192, it is not part of item (item is
[4096, 8191]). But the comparison is false and we think we have found
the correct item, although we should be searing in the right subtree.
This fixes some bugs I encountered.
Signed-off-by: Marek Behun <marek.behun@nic.cz>
Diffstat (limited to 'fs/btrfs')
| -rw-r--r-- | fs/btrfs/chunk-map.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/btrfs/chunk-map.c b/fs/btrfs/chunk-map.c index beb6a4bb92..0c9a659f8f 100644 --- a/fs/btrfs/chunk-map.c +++ b/fs/btrfs/chunk-map.c @@ -78,7 +78,7 @@ u64 btrfs_map_logical_to_physical(u64 logical) if (item->logical > logical) node = node->rb_left; - else if (logical > item->logical + item->length) + else if (logical >= item->logical + item->length) node = node->rb_right; else return item->physical + logical - item->logical; |